Github Actions fix for reference to OpenSearch-Dashboard not existing outside of main OS sql project #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
=============================================
- Coverage 94.74% 62.76% -31.99%
=============================================
Files 283 10 -273
Lines 7676 658 -7018
Branches 560 118 -442
=============================================
- Hits 7273 413 -6860
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
…on file. Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
…move. Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
MitchellGale
force-pushed
the
integ-gha_fix_nvmrc
branch
from
403355a to
2cadeb9
Compare
acarbonetto
approved these changes
Jul 21, 2022
… integ-gha_fix_nvmrc
joshuali925
approved these changes
Jul 25, 2022
6 tasks
dai-chen
approved these changes
Aug 4, 2022
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 5, 2022
…h-project#704. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 5, 2022
* Fix java installation for SQL plugin workflow; * Backport workbench CI fixes from opensearch-project#588 and opensearch-project#704. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves issue with OpenSearch-Dashboards reference not working outside of main opensearch-project/sql repo for github actions. Resolution was to remove
sql/before path insql-workbench-test-and-build-workflow.ymland fix following references to OpenSearch-Dashboards.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.