-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jackson to 2.14.1 and fix dependency resolution issues #1159
Conversation
38d9126
to
8b41d44
Compare
Codecov Report
@@ Coverage Diff @@
## main #1159 +/- ##
=========================================
Coverage 94.83% 94.83%
Complexity 2916 2916
=========================================
Files 291 291
Lines 7795 7795
Branches 568 568
=========================================
Hits 7392 7392
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
8b41d44
to
19dee45
Compare
@@ -77,7 +79,7 @@ dependencies { | |||
include '*.jar' | |||
builtBy 'compileJdbc' | |||
} | |||
testImplementation group: 'com.h2database', name: 'h2', version: '2.1.210' | |||
testImplementation group: 'com.h2database', name: 'h2', version: '2.1.214' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures are not related and caused by opensearch-project/OpenSearch#5515 |
api "com.fasterxml.jackson.core:jackson-databind:${jackson_version}" | ||
api "com.fasterxml.jackson.core:jackson-annotations:${jackson_version}" | ||
// Bundled with the OpenSearch (https://github.com/opensearch-project/OpenSearch/pull/5366) | ||
compileOnly "com.fasterxml.jackson.core:jackson-databind:${jackson_version}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the dependency scope because of opensearch-project/OpenSearch@c6663fd
@reta, thanks for PR. SQL plugin does not working on main currently. Our plan is
With merge 2.x to main, We will merge everything from 2.x to main, and will pickup #1150 automatically. |
Thanks @penghuo , I will create a pull request for opensearch-project/OpenSearch@c6663fd only |
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
Port #1150 to
main
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.