-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add micro benchmark by JMH #1278
Merged
dai-chen
merged 8 commits into
opensearch-project:main
from
dai-chen:test-mircro-benchmark
Jan 23, 2023
Merged
Add micro benchmark by JMH #1278
dai-chen
merged 8 commits into
opensearch-project:main
from
dai-chen:test-mircro-benchmark
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
added
the
infrastructure
Changes to infrastructure, testing, CI/CD, pipelines, etc.
label
Jan 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
=========================================
Coverage 98.34% 98.34%
Complexity 3600 3600
=========================================
Files 343 343
Lines 8908 8908
Branches 567 567
=========================================
Hits 8761 8761
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
penghuo
reviewed
Jan 17, 2023
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Yury-Fridlyand
approved these changes
Jan 19, 2023
acarbonetto
approved these changes
Jan 19, 2023
penghuo
approved these changes
Jan 23, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Add benchmark module and test implicit cast Signed-off-by: Chen Dai <daichen@amazon.com> * Benchmark the second approach from Yury Signed-off-by: Chen Dai <daichen@amazon.com> * Refactor code to make benchmark module for future use Signed-off-by: Chen Dai <daichen@amazon.com> * Add readme Signed-off-by: Chen Dai <daichen@amazon.com> * Move benchmark class to right source location Signed-off-by: Chen Dai <daichen@amazon.com> * Change depedency accessiblity from api to impl Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> (cherry picked from commit ff9ac16)
dai-chen
added a commit
that referenced
this pull request
Jan 23, 2023
* Add benchmark module and test implicit cast Signed-off-by: Chen Dai <daichen@amazon.com> * Benchmark the second approach from Yury Signed-off-by: Chen Dai <daichen@amazon.com> * Refactor code to make benchmark module for future use Signed-off-by: Chen Dai <daichen@amazon.com> * Add readme Signed-off-by: Chen Dai <daichen@amazon.com> * Move benchmark class to right source location Signed-off-by: Chen Dai <daichen@amazon.com> * Change depedency accessiblity from api to impl Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> (cherry picked from commit ff9ac16) Co-authored-by: Chen Dai <daichen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add a new
benchmarks
module for ad-hoc microbenchmark on class level. This was motivated by discussion in #1196 (comment). For now we just use this for local ad-hoc benchmark test before submitting PR. We can explore https://github.com/marketplace/actions/continuous-benchmark for automation and performance degradation detect later.Test
I added 1 benchmark class
ComparisonOperatorBenchmark
as an example.Documentation
Please find more details in https://github.com/dai-chen/sql-1/blob/test-mircro-benchmark/benchmarks/README.md. Reference: https://github.com/opensearch-project/OpenSearch/blob/main/benchmarks/README.md
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.