Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link checker CI workflow. #1304

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury-Fridlyand yury.fridlyand@improving.com

Description

Fix link checker CI workflow.

Issues Resolved

Link checker was failing without any error produced.
image

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner January 27, 2023 23:59
@Yury-Fridlyand
Copy link
Collaborator Author

Actually, it still doesn't work properly, because current README has broken links...

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #1304 (9395b0b) into main (45fc371) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1304   +/-   ##
=========================================
  Coverage     98.35%   98.35%           
  Complexity     3627     3627           
=========================================
  Files           343      343           
  Lines          8951     8951           
  Branches        578      578           
=========================================
  Hits           8804     8804           
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 30, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 15d3ce0 into opensearch-project:main Jan 30, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the dev-fix-linkchecker-ci branch January 30, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants