Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RINT function to V2 engine #1433

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

matthewryanwells
Copy link
Contributor

Description

Added math function RINT to V2 engine, updated documentation, and added unit/IT tests. Additionally fixed small typo in the EXPM1 description

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added RINT to V2 engine, updated documentation, added unit and IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@matthewryanwells matthewryanwells requested a review from a team as a code owner March 13, 2023 21:16
@codecov-commenter
Copy link

Codecov Report

Merging #1433 (39a9214) into main (98fb969) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1433      +/-   ##
============================================
- Coverage     98.38%   98.38%   -0.01%     
  Complexity     3698     3698              
============================================
  Files           343      343              
  Lines          9121     9118       -3     
  Branches        586      582       -4     
============================================
- Hits           8974     8971       -3     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...expression/function/BuiltinFunctionRepository.java 100.00% <100.00%> (ø)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen merged commit 7220cfe into opensearch-project:main Mar 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
Added RINT to V2 engine, updated documentation, added unit and IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 7220cfe)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 15, 2023
Added RINT to V2 engine, updated documentation, added unit and IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 7220cfe)

Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants