Fix null response from pow/power and added missing integration testing #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function. Signed-off-by: Matthew Wells <matthew.wells@improving.com>
10 tasks
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1457 +/- ##
============================================
+ Coverage 98.39% 98.46% +0.06%
- Complexity 3713 3850 +137
============================================
Files 343 345 +2
Lines 9155 9557 +402
Branches 582 615 +33
============================================
+ Hits 9008 9410 +402
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yury-Fridlyand
approved these changes
Mar 21, 2023
dai-chen
approved these changes
Mar 21, 2023
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Mar 22, 2023
#1457) (#1459) * Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function. Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit a35f963) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed implementation of pow and power such that when an invalid response would be returned from having a negative base and a floating point exponent it returns null instead of crashing.
In addition I also added integration testing which was previously missing.
Issues Resolved
#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.