-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation of round function return type #1725
Updated documentation of round function return type #1725
Conversation
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Codecov Report
@@ Coverage Diff @@
## main #1725 +/- ##
=========================================
Coverage 97.29% 97.29%
Complexity 4408 4408
=========================================
Files 388 388
Lines 10944 10944
Branches 774 774
=========================================
Hits 10648 10648
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Is it related to #1138? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing changed in docs, but I think you can fix #1138 as far as you're here. It returns DOUBLE
in some cases.
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
It has been confirmed that #1138 was not actually a bug |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
* fixed round documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit 34cad6e)
…ct#1725) * fixed round documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Description
Small fix to incorrect return type in the round function documentation, below in the function implementation in
org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
that it should be either returninglong
ordouble
depending if the first variable was either integer/long or float/double respectively.Issues Resolved
No connected issue
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.