Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min max skipping index #1726

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jun 8, 2023

Description

Added MinMax skipping index similarly as ValueSet skipping index.

Note that because both min and max value of the given column needs to be stored, MinMax_${columnName}_0 and MinMax_${columnName}_1 are used to avoid conflict with other existing column. Afterwards, will check if other skipping index should follow the same naming convention (currently they all have single output column and thus same name as given column name).

Issues Resolved

opensearch-project/opensearch-spark#2

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added enhancement New feature or request Flint labels Jun 8, 2023
@dai-chen dai-chen self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1726 (f3ef196) into feature/flint (e80cf9b) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    opensearch-project/sql#1726   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

dai-chen added 2 commits June 13, 2023 09:36
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen force-pushed the add-min-max-index branch from 7227b80 to cbc8a33 Compare June 13, 2023 16:39
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review June 13, 2023 17:11
@dai-chen dai-chen requested a review from penghuo June 13, 2023 17:11
@dai-chen dai-chen merged commit 65583d6 into opensearch-project:feature/flint Jun 20, 2023
@dai-chen dai-chen deleted the add-min-max-index branch June 20, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants