Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flint drop index SQL support #1730

Merged

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jun 10, 2023

Description

Add Flint SQL support by ANTLR. Use DROP SKIPPING INDEX as first statement for simplicity.

Note that:

  1. Separate FlintSpark.g4 (Flint extended SQL syntax) and SparkSqlBase.g4 (Spark identifier rule and lexical tokens)
  2. Follow Spark command convention and returns empty from Flint Create/Drop DDL too.

Issues Resolved

opensearch-project/opensearch-spark#2

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added enhancement New feature or request Flint labels Jun 10, 2023
@dai-chen dai-chen self-assigned this Jun 10, 2023
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #1730 (32d7320) into feature/flint (e80cf9b) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    opensearch-project/sql#1730   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

dai-chen added 3 commits June 19, 2023 17:27
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen changed the title Add Flint SQL support Add Flint drop index SQL support Jun 20, 2023
@dai-chen dai-chen merged commit ae3389d into opensearch-project:feature/flint Jun 21, 2023
@dai-chen dai-chen deleted the add-flint-sql-support branch June 21, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants