Provide hybrid scan setting for consistency requirement #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Codecov Report
@@ Coverage Diff @@
## feature/flint opensearch-project/sql#1819 +/- ##
================================================
Coverage 97.19% 97.19%
Complexity 4107 4107
================================================
Files 371 371
Lines 10464 10464
Branches 706 706
================================================
Hits 10170 10170
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
penghuo
reviewed
Jul 11, 2023
| partitions | ||
| .flatMap(_.files.map(f => f.getPath.toUri.toString)) | ||
| .toDF(FILE_PATH_COLUMN) | ||
| .join(indexScan, Seq(FILE_PATH_COLUMN), "left") |
There was a problem hiding this comment.
i assume left join is expensive, is there an magic number to avoid left join, which mean scan without index? if it make sense, we can add an issue to track it at perf test stage.
There was a problem hiding this comment.
Sure, will cover this in our benchmark after merged. Thanks!
penghuo
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add hybrid scan mode which covers the latest source files that haven't refreshed to Flint index yet:
Issues Resolved
opensearch-project/opensearch-spark#2
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.