Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build from Upstream Refactor #1883

Merged

Conversation

forestmvey
Copy link
Collaborator

Description

Fixes for upstream refactor 8730.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
@forestmvey forestmvey force-pushed the integ-hppc-refactor branch from 9d78d70 to 1613d3c Compare July 18, 2023 18:59
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1883 (9d78d70) into main (8c8e08c) will not change coverage.
The diff coverage is n/a.

❗ Current head 9d78d70 differs from pull request most recent head 1613d3c. Consider uploading reports for the commit 1613d3c to get more accurate results

@@            Coverage Diff            @@
##               main    #1883   +/-   ##
=========================================
  Coverage     97.39%   97.39%           
  Complexity     4608     4608           
=========================================
  Files           401      401           
  Lines         11408    11408           
  Branches        843      843           
=========================================
  Hits          11111    11111           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <ø> (ø)

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore BWC for now

@Yury-Fridlyand Yury-Fridlyand merged commit f4883c9 into opensearch-project:main Jul 18, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-hppc-refactor branch July 18, 2023 19:44
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 18, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 19, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 28, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants