Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for common #7 #1940

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

MitchellGale
Copy link
Contributor

@MitchellGale MitchellGale commented Aug 5, 2023

Description

Applies spotless for Google Java Code Format for the common directory.

Note: #889 for the codeql bot comments below.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '%{{0=' and containing many repetitions of 'z'.
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '%{{0=' and containing many repetitions of '.'.
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #1940 (baacd66) into main (245c4f8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1940   +/-   ##
=========================================
  Coverage     97.51%   97.51%           
  Complexity     4657     4657           
=========================================
  Files           408      408           
  Lines         11933    11933           
  Branches        829      829           
=========================================
  Hits          11637    11637           
  Misses          289      289           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

GumpacG
GumpacG previously approved these changes Aug 8, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 8, 2023
@MitchellGale MitchellGale dismissed stale reviews from Yury-Fridlyand and GumpacG via eaea0e9 August 10, 2023 19:24
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 10, 2023
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale and others added 2 commits August 14, 2023 12:40
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@MitchellGale MitchellGale force-pushed the integ/sl_GoogleJavaFormat7 branch from dee7452 to baacd66 Compare August 14, 2023 19:41
@GumpacG GumpacG merged commit e377cf2 into opensearch-project:main Aug 14, 2023
@MitchellGale MitchellGale deleted the integ/sl_GoogleJavaFormat7 branch August 14, 2023 21:21
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…ect#1940)

* Spotless apply for common directory.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Igoring checkstyle for common

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply on string utils,

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Typo fix

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…ect#1940)

* Spotless apply for common directory.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Igoring checkstyle for common

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply on string utils,

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Typo fix

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
…ect#1940)

* Spotless apply for common directory.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Igoring checkstyle for common

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply on string utils,

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Typo fix

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants