Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Applying Google Code Format for core #5 #1951

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

MitchellGale
Copy link
Contributor

Description

Based off #1930, #1931. #1932. #1933 and applies spotless to entire core project. Covers remaining fixes not covered by PR 1-4.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MitchellGale and others added 2 commits August 9, 2023 15:57
Adding core final GJF fix.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1951 (c22fca1) into main (7d23e0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1951   +/-   ##
=========================================
  Coverage     97.51%   97.51%           
  Complexity     4657     4657           
=========================================
  Files           408      408           
  Lines         11930    11931    +1     
  Branches        830      830           
=========================================
+ Hits          11633    11634    +1     
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...g/opensearch/sql/data/model/AbstractExprValue.java 100.00% <ø> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <100.00%> (ø)
...org/opensearch/sql/data/type/WideningTypeRule.java 100.00% <100.00%> (ø)

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 10, 2023
@Yury-Fridlyand
Copy link
Collaborator

Please, fix CI

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 91bbb5d into opensearch-project:main Aug 10, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ/sl_GJF5 branch August 10, 2023 17:56
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 14, 2023
…t#1951)

* Integ/sl google java format5 (#332)

Adding core final GJF fix.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* remove repeated unused checkstyle.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* replaced nbsp with pre tag.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Add test fixtures to failure ignore in core build.gradle.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 18, 2023
…t#1951)

* Integ/sl google java format5 (#332)

Adding core final GJF fix.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* remove repeated unused checkstyle.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* replaced nbsp with pre tag.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Add test fixtures to failure ignore in core build.gradle.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)

* spotlesss apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* fixed target for spotless

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* fixed comments of spotless

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants