Make aggregation statement compilation robust #2781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to address the weakness of query compilation for aggregation statement, including query with aggregate function, window function, group-by clause etc.
Here are some examples to demo what this PR fixes. The reproduce details is here
null
Field [query_id] must appear in the GROUP BY clause or be used in an aggregate function
Explicit GROUP BY clause is required because expression [query_id] contains non-aggregated column
Explicit GROUP BY clause is required because expression [query_id] contains non-aggregated column
Server side error during query execution
Aggregate function is not allowed in a GROUP BY clause, but found [max]
Server side error during query execution
Aggregate function is not allowed in a GROUP BY clause, but found [max]
Client side error during query execution: [filter] must not be null
FILTER or HAVING expression must be type boolean, but found [LONG]
Server side error during query execution
Aggregate function is not allowed in a FILTER, but found [max]
Server side error during query execution
window functions are not allowed in WHERE or HAVING
Issues Resolved
Resolves #2767, #910,
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.