Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict UDF functions #2790

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Restrict UDF functions #2790

merged 1 commit into from
Jul 19, 2024

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Jun 28, 2024

Description

This PR blocks UDF creation queries in async query api.

Issues Resolved

#2761

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vmmusings vmmusings self-assigned this Jun 28, 2024
@vmmusings vmmusings added enhancement New feature or request backport 2.x labels Jun 28, 2024
@vmmusings vmmusings linked an issue Jun 28, 2024 that may be closed by this pull request
@vmmusings vmmusings added bug Something isn't working and removed enhancement New feature or request labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (956ec15) to head (c3cd3f3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2790   +/-   ##
=========================================
  Coverage     94.60%   94.61%           
- Complexity     5141     5145    +4     
=========================================
  Files           508      508           
  Lines         14474    14493   +19     
  Branches        944      945    +1     
=========================================
+ Hits          13693    13712   +19     
  Misses          740      740           
  Partials         41       41           
Flag Coverage Δ
sql-engine 94.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vmmusings vmmusings merged commit db2bd66 into opensearch-project:main Jul 19, 2024
14 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2790-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db2bd6619453a320eadd741df8ca318a905f3fa4
# Push it to GitHub
git push --set-upstream origin backport/backport-2790-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2790-to-2.x.

vmmusings added a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit db2bd66)
vmmusings added a commit that referenced this pull request Aug 1, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit db2bd66)
vmmusings added a commit that referenced this pull request Aug 1, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit db2bd66)
vmmusings added a commit that referenced this pull request Aug 1, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit db2bd66)
manasvinibs pushed a commit to manasvinibs/sql that referenced this pull request Aug 14, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Restrict UDF functions in spark SQL.
4 participants