[Manual Backport] Backport doctest fix to 2.x #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit cf1564b)
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
Swiddis
added
the
infrastructure
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
noCharger
reviewed
Oct 22, 2024
There was a problem hiding this comment.
> Task :sql:jacocoTestReport
FAILURE: Build failed with an exception.
> Task :sql:check
* What went wrong:
Execution failed for task ':integ-test:integTest'.
> There were failing tests. See the report at: file:///__w/sql/sql/integ-test/build/reports/tests/integTest/index.html
Does any other PR fix this?
Swiddis
added
v2.18.0
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
|
Additionally copied import fix from #3113 |
This reverts commit 5efb64c. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #3087 +/- ##
=========================================
Coverage 94.54% 94.54%
Complexity 5454 5454
=========================================
Files 529 529
Lines 15600 15600
Branches 1027 1027
=========================================
Hits 14749 14749
Misses 804 804
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
noCharger
approved these changes
Oct 24, 2024
penghuo
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3053
Related Issues
N/A
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.