Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport] Backport doctest fix to 2.x #3087

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 21, 2024

Description

Backport of #3053

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Swiddis and others added 3 commits October 7, 2024 09:52
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
(cherry picked from commit cf1564b)
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


> Task :sql:jacocoTestReport
FAILURE: Build failed with an exception.

> Task :sql:check
* What went wrong:
Execution failed for task ':integ-test:integTest'.
> There were failing tests. See the report at: file:///__w/sql/sql/integ-test/build/reports/tests/integTest/index.html

Does any other PR fix this?

@Swiddis
Copy link
Collaborator Author

Swiddis commented Oct 23, 2024

#3084

@Swiddis Swiddis added v2.18.0 Issues targeting release v2.18.0 and removed v2.18.0 Issues targeting release v2.18.0 labels Oct 23, 2024
@noCharger
Copy link
Collaborator

#3084

@Swiddis since this one is merged, could you rebase and verify doctest passed?

@Swiddis Swiddis mentioned this pull request Oct 23, 2024
7 tasks
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Oct 23, 2024

Additionally copied import fix from #3113

This reverts commit 5efb64c.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Oct 23, 2024

Nvm, #3113's broken PR wasn't backported yet so we don't need the import fix here (fixed backport for #3115)

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (f6ca54c) to head (f309ff1).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #3087   +/-   ##
=========================================
  Coverage     94.54%   94.54%           
  Complexity     5454     5454           
=========================================
  Files           529      529           
  Lines         15600    15600           
  Branches       1027     1027           
=========================================
  Hits          14749    14749           
  Misses          804      804           
  Partials         47       47           
Flag Coverage Δ
sql-engine 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penghuo penghuo merged commit 173737c into opensearch-project:2.x Oct 25, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants