Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off doctests from main tests #3103

Closed

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 23, 2024

Description

Following in the footsteps of #3070, this PR splits doctests into its own step too. The general motivation behind both changes is that both suites can start failing due to factors outside this repo (doctests if CLI changes, BWC if lucene codec changes), but integ tests should always pass. Since issues were recently caused by missing failing integ tests (hidden by doctest/BWC failures that were unrelated to the changes), having them in their own checks to make integ test failures visible at a glance would have prevented the issue. It also makes the actions run faster.

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Oct 23, 2024
@Swiddis
Copy link
Collaborator Author

Swiddis commented Nov 4, 2024

Closing as dead in draft for now, hoping to try again later but not much spare bandwidth

@Swiddis Swiddis closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant