Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Streaming source impl #994

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 31, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

  • Add generice StreamingSource interface.
  • Add FileSystemStreamingSource implementation base on hadoop fs.
  • Exclude uncessary depedency from hadoop-commons, the opensearch-sql.zip size is around 50M. (currently, 33M)
  • More info Add Stream Source #969.

Future Work

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #994 (e2e3cd8) into feature/maximus-m1 (eea2689) will decrease coverage by 35.51%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             feature/maximus-m1     #994       +/-   ##
=========================================================
- Coverage                 98.27%   62.76%   -35.52%     
=========================================================
  Files                       339       10      -329     
  Lines                      8545      658     -7887     
  Branches                    561      119      -442     
=========================================================
- Hits                       8398      413     -7985     
- Misses                      142      192       +50     
- Partials                      5       53       +48     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/sql/SQLService.java
...nsearch/sql/expression/aggregation/Aggregator.java
...h/sql/expression/conditional/cases/WhenClause.java
...age/serialization/DefaultExpressionSerializer.java
...nsearch/sql/planner/physical/RareTopNOperator.java
.../filter/lucene/relevance/MatchBoolPrefixQuery.java
...sql/opensearch/request/OpenSearchQueryRequest.java
...h/planner/logical/rule/PushProjectAndRelation.java
...ilter/lucene/relevance/MatchPhrasePrefixQuery.java
...ch/storage/script/filter/lucene/WildcardQuery.java
... and 339 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo force-pushed the hp/feature/maximus/streamingsource branch from 9776f9d to 7b6a1e2 Compare November 1, 2022 16:17
@penghuo penghuo added the feature label Nov 1, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo self-assigned this Nov 1, 2022
@penghuo penghuo marked this pull request as ready for review November 1, 2022 18:53
@penghuo penghuo requested a review from a team as a code owner November 1, 2022 18:53
@penghuo penghuo marked this pull request as draft November 3, 2022 04:13
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review November 3, 2022 23:49
Signed-off-by: Peng Huo <penghuo@gmail.com>
…urce

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen merged commit 5105022 into opensearch-project:feature/maximus-m1 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants