Update vexflow to the latest version 🚀

[greenkeeper]

---

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

---

The dependency vexflow was updated from 1.2.90 to 1.2.91.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

Publisher: 0xfe
License: MIT

Find out more about this release.

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper bot 🌴

[sschmidTU]

From 0xfe's google groups update:

One major change: package.json now uses 'src/index.js' as the main file instead of 'releases/vexflow-debug.js'. If you're using vexflow packages in a standard way, this should significantly improve your bundle sizes without disrupting anything.

Please let me know if this breaks your code, I'll investigate and try to figure out the best path forward.

So maybe we just need to use index.js instead of vexflow-debug.js

[sschmidTU]

Maybe this will help too:

[how i used to import vexflow:]
import * as Vex from 'vexflow';

but now only works with

import Vex from 'vexflow';

in any case, Mo will probably respond with some interesting info in that topic.

(i haven't really looked into fixing Vexflow 1.2.91 import in OSMD yet, just happened to notice this)

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 1.2.92.

Update to this version instead 🚀

Commits

The new version differs by 7 commits.

• edfa3fb Committing release binaries for new version: 1.2.92
• a1c8d68 Release v1.2.92
• fd94be0 Fix #748: Use consistent widths for clefs, so staves are aligned.
• 36c228e More cleanup: rename note_data to noteStruct
• 9ff3928 More cleanup: create validTypes map
• 08c406d Rename durationToGlyph to getGlyphCodes
• 059c545 Remove Vex.Merge from durationToGlyph.

See the full diff

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 1.2.93.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.1.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.4.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.5.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.6.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.7.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.8.

Update to this version instead 🚀

[greenkeeper]

• The dependency vexflow was updated from 1.2.90 to 3.0.9.

Update to this version instead 🚀

[sschmidTU]

Vexflow 1.2.90 to 1.2.91:
some noteheads fixed (notehead position in relation to stem was off),
time signature slightly changed in y position

[sschmidTU]

Vexflow 1.2.91 to 1.2.92:
formatting slightly changed: first measure takes slightly more space (before first notes),
first notes and modifiers of vertically parallel stafflines better x-synchronized
(sometimes the first note of the first measure on piano right hand wasn't on the same vertical imaginary line through the sheet as the one in the left hand)

some bounding boxes seem to be improved, sometimes a dynamic or lyric doesn't overlap notes anymore (Land der Berge, Schubert An die Musik)

[sschmidTU]

Vexflow 1.9.2 to 1.2.93:
more notehead fixes

Vexflow 1.9.3 to 3.0.1:
(not merged yet)
layout much more condensed (uses less space), usually looking better, sometimes a bit cramped maybe
tremolo slashes now start from beginning of stem, not end of stem (not sure if that's better, but it leaves more space for more slashes)

some bugs:
half notes in a measure make measure extremely long (function test Notehead Shapes, Land der Berge measure 9),
rest notes wrong x-position, sometimes into next measure (function test Accidentals),
seems like bounding box of measure is wrong (function test Invisible Notes: lyrics overlap into next measure. we check for lyrics and measure length here and elongate measure when there's overlap given by the bounding boxes),
tuplet brackets overlap (function test all),
grace note overlaps with time signature in Debussy - Mandoline

[sschmidTU]

Vexflow 3.0.1 to 3.0.3:
fixes most of the bugs in 3.0.1, except the tuplet bracket overlaps (not important or severe though)
layout is very tight now though, e.g. with function test Tabulature, fingerings are borderline overlapping, almost no spacing.
layout sometimes takes more space total again

[sschmidTU]

Vexflow 3.0.3 to 3.0.4:
fixes some more bounding box issues and overlaps,
generally better layout, giving some elements more room and spacing,
but makes cramping even worse in function test Tabulature, overlap of fingering with dot of dotted notes (in visual regression test)
actually, in the local demo, it mostly looks fine, probably depends on format. bar 10 has a slighly condensed and weird layout (half note again), but it's not too bad.

[sschmidTU]

merging 3.0.4, up to date with Vexflow again.
some changes may look slightly worse, but overall, the improvements far outweigh that.

(build passed on Travis Appveyor build fixed with update of nodejs to 12 like Travis and #723)

[sschmidTU]

Vexflow 3.0.4 to 3.0.5:
layout changed again, sometimes more spacious, sometimes more constricted, short notes at the end of measure way too far to the left in Dichterliebe:

(black is 3.0.5)
more space in function test Tabulature, but note overlap in bar 15:

let's see if this is fixed again in the next versions

Vexflow 3.0.5 to 3.0.6:
layout often completely wrong, sequential notes vertically synced, notes going over measure
Ferne Geliebte:

Dichterliebe (measure 7):

Vexflow 3.0.6 to 3.0.7:
fixes the problems in 3.0.6, but adds some measure overlap again:

(Land der Berge measure 2-3)
also makes some measures with half notes too long again (An Chloe, measure 6):

Vexflow 3.0.7 to 3.0.8:
doesn't fix the problems of 3.0.7,
but gives the layout a bit more space:

it also syncs up first rest notes in measures, which is good in principle, but can give new conflicts with metronome marks, e.g. Debussy Mandoline:

Vexflow 3.0.8 to 3.0.9:
Introduces some measure overlap again, Bach Air measure 3-4:

diff:

as of now, probably better not to update OSMD past 3.0.4, as there are some unresolved issues.
Should open issue at Vexflow (check if there are some already).