Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15570: Enable BMC form in Add hosts modal, for all platforms, if provisioning configuration exists #2323

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

batzionb
Copy link
Contributor

@batzionb batzionb commented Sep 4, 2023

Provisioning configuration exists - BMC options are enabled with no help icon

No provisioning configuration - BMC options are disabled and there's a help icon explaining why and links to console default create page of Provisioning configuration

image

Provisioning configuration loading - BMC options are disabled and showing spinner

Peek 2023-09-04 16-26

Error loading Provisioning configuration - The BMC options are enabled and the error shows at the top of the modal
image

@batzionb batzionb requested a review from a team as a code owner September 4, 2023 13:20
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2023

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2023

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to this:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2023

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to this:

No provisioning configuration

image

Provisioning configuration loading

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2023

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to this:

Provisioning configuration exists - BMC options are enabled with no help icon

No provisioning configuration - BMC options are disabled and there's a help icon explaining why

image

Provisioning configuration loading - BMC options are disabled and showing spinner

Peek 2023-09-04 16-26

Error loading Provisioning configuration - The BMC options are enabled and the error shows at the top of the modal
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@batzionb batzionb force-pushed the MGMT-15570 branch 6 times, most recently from e273833 to c1b1115 Compare September 4, 2023 19:19
ammont82
ammont82 previously approved these changes Sep 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2023

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to this:

Provisioning configuration exists - BMC options are enabled with no help icon

No provisioning configuration - BMC options are disabled and there's a help icon explaining why and links to console default create page of Provisioning configuration

image

Provisioning configuration loading - BMC options are disabled and showing spinner

Peek 2023-09-04 16-26

Error loading Provisioning configuration - The BMC options are enabled and the error shows at the top of the modal
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, batzionb, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

New changes are detected. LGTM label has been removed.

@jkilzi jkilzi merged commit 48e2d43 into openshift-assisted:master Sep 6, 2023
7 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants