Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-7525: Removes obsolete feature-toggles #2326

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

jkilzi
Copy link
Collaborator

@jkilzi jkilzi commented Sep 5, 2023

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2023

@jkilzi: This pull request references MGMT-7525 which is a valid jira issue.

In response to this:

Signed-off-by: Jonathan Kilzi jkilzi@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 5, 2023
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2023
Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
@jkilzi jkilzi marked this pull request as ready for review September 5, 2023 11:11
@jkilzi jkilzi requested a review from a team as a code owner September 5, 2023 11:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2023

@jkilzi: This pull request references MGMT-7525 which is a valid jira issue.

In response to this:

Signed-off-by: Jonathan Kilzi jkilzi@redhat.com

OCM's couterpart MR: https://gitlab.cee.redhat.com/service/uhc-portal/-/merge_requests/4503

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@jkilzi jkilzi added this to the v2.25 milestone Sep 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 6d9581d into openshift-assisted:master Sep 5, 2023
14 checks passed
@jkilzi jkilzi deleted the tasks/MGMT-7525 branch September 5, 2023 12:19
jkilzi added a commit that referenced this pull request Sep 5, 2023
(Backports #2326)
* Removes traces of ASSISTED_INSTALLER_PLATFORM_OCI
* Removes traces of ASSISTED_INSTALLER_SNO_FEATURE
* Removes traces of ASSISTED_INSTALLER_OCS_FEATURE
* Removes traces of ASSISTED_INSTALLER_ODF_FEATURE
* Removes traces of ASSISTED_INSTALLER_CNV_FEATURE
Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
jkilzi added a commit to jkilzi/assisted-installer-ui that referenced this pull request Sep 6, 2023
jkilzi added a commit to jkilzi/assisted-installer-ui that referenced this pull request Sep 6, 2023
jkilzi added a commit that referenced this pull request Sep 6, 2023
jkilzi added a commit that referenced this pull request Sep 6, 2023
ammont82 pushed a commit to ammont82/assisted-installer-ui that referenced this pull request Sep 8, 2023
* Removes traces of ASSISTED_INSTALLER_PLATFORM_OCI

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_SNO_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_OCS_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_ODF_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_CNV_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

---------

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
ammont82 pushed a commit to ammont82/assisted-installer-ui that referenced this pull request Sep 8, 2023
* Removes traces of ASSISTED_INSTALLER_PLATFORM_OCI

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_SNO_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_OCS_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_ODF_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_CNV_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

---------

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
ammont82 added a commit that referenced this pull request Sep 8, 2023
* Removes traces of ASSISTED_INSTALLER_PLATFORM_OCI



* Removes traces of ASSISTED_INSTALLER_SNO_FEATURE



* Removes traces of ASSISTED_INSTALLER_OCS_FEATURE



* Removes traces of ASSISTED_INSTALLER_ODF_FEATURE



* Removes traces of ASSISTED_INSTALLER_CNV_FEATURE



---------

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
ammont82 pushed a commit to ammont82/assisted-installer-ui that referenced this pull request Sep 8, 2023
ammont82 added a commit that referenced this pull request Sep 8, 2023
…#2343)

The issue was introduced in #2326

Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
* Removes traces of ASSISTED_INSTALLER_PLATFORM_OCI

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_SNO_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_OCS_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_ODF_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

* Removes traces of ASSISTED_INSTALLER_CNV_FEATURE

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>

---------

Signed-off-by: Jonathan Kilzi <jkilzi@redhat.com>
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants