This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Fix a bug where upstream git commit was incorrectly pinned for stream… #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfreex
force-pushed
the
fix-rebase-stream-assembly
branch
from
c45deec to
cb12b0d
Compare
… assembly Commit 0917797 introduced a new behavior to prevent from rebuilding images/rpms off their latest commits for non-stream assemblies. However, assembly related fields in `class Runtime` are initialized too late, which results in stream assembly builds are also pinned to their latest upstream commits. This PR moves up the code for initializing assembly related fields and explicitly checks `assembly_basis_event` to decide whether pinning a commit is needed or not.
vfreex
force-pushed
the
fix-rebase-stream-assembly
branch
from
cb12b0d to
3d35639
Compare
Build #1 |
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
===========================================
+ Coverage 0 32.52% +32.52%
===========================================
Files 0 42 +42
Lines 0 10377 +10377
Branches 0 2166 +2166
===========================================
+ Hits 0 3375 +3375
- Misses 0 6794 +6794
- Partials 0 208 +208
Continue to review full report at Codecov.
|
vfreex
added a commit
to vfreex/doozer
that referenced
this pull request
Aug 9, 2021
dbe3d91 Fix a bug where upstream git commit was incorrectly pinned for stream assembly (openshift-eng#495) 084baa1 Turn git commit into a parsable yaml document This will allow our automation to be able to detect source and commit information without having to parse RPM spec files. 0917797 Build basis locked assemblies artifacts from their lastet build's upstream commit c61bd43 Make evaluation of -alt image deterministic e398878 Use unaltered git url to assess whether images are siblings 7d21721 Fixes for building from a specific commit 16f1e44 Allow assemblies to override streams 2a69d50 Do not write duplicate destinations 6821b79 Add emergency override b908fe5 Gen-assembly from GA releases and default stream permits 788ae1e Reintroduce hotfix tagging f4c42b7 Formalizing assembly issues and permitting them 20fdd0c Mitigate GSSAPIAuthError (openshift-eng#487) 5b7d850 Gen-payload for assembly fixes and updates for PR comments cea8804 Make gen-payload enforce assembly consistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… assembly
Commit 0917797 introduced a new
behavior to prevent from rebuilding images/rpms off their latest commits
for non-stream assemblies.
However, assembly related fields in
class Runtimeare initialized too late,which results in stream assembly builds are also pinned to their latest
upstream commits.
This PR moves up the code for initializing assembly related fields and
explicitly checks
assembly_basis_eventto decide whether pinning a commit is needed or not.