Align EKB and eventing-core installed versions for e2e tests

[creydr]

Align the installed version of EKB and eventing-core for tests.

Make use of USE_RELEASE_NEXT and make generated-files-release-next from openshift-knative/serverless-operator#2528

Testrun in #1026 and #994

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[creydr]

Testrun on release-v1.12 branch (#994):

Aligned version with branch of EKB (--> used v1.12 for eventing-core):

        {
            "apiVersion": "v1",
            "kind": "Pod",
            "metadata": {
                ...
                "labels": {
                    "app": "eventing-controller",
                    "app.kubernetes.io/component": "eventing-controller",
                    "app.kubernetes.io/name": "knative-eventing",
                    "app.kubernetes.io/version": "v1.12",
                    "pod-template-hash": "84b9ffbd7"
                },
                "name": "eventing-controller-84b9ffbd7-66hxt",

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift-knative_eventing-kafka-broker/994/pull-ci-openshift-knative-eventing-kafka-broker-release-v1.12-414-test-e2e-aws-414/1769632228553265152/artifacts/test-e2e-aws-414/openshift-gather-extra/artifacts/pods.json

Testrun on release-next branch (#1026):
Installed nightly for eventing-core (see #1026 (comment))

            "kind": "Pod",
            "metadata": {
                "creationTimestamp": "2024-03-15T23:31:25Z",
                "generateName": "eventing-controller-bf99fc574-",
                "labels": {
                    "app": "eventing-controller",
                    "app.kubernetes.io/component": "eventing-controller",
                    "app.kubernetes.io/name": "knative-eventing",
                    "app.kubernetes.io/version": "nightly",
                },
                "name": "eventing-controller-bf99fc574-8hcqw",

[creydr]

/cc @matzew @pierDipi

[creydr]

/cc @mgencur

[creydr]

/assign @matzew @pierDipi

[pierDipi]

@creydr @mgencur in this form, we would only support release next, I believe if we make the branch/version configurable instead of hardcoding release-next in SO ( and default it to use project.yaml configurations) we could leverage it in any branch

[mgencur]

@creydr @mgencur in this form, we would only support release next, I believe if we make the branch/version configurable instead of hardcoding release-next in SO ( and default it to use project.yaml configurations) we could leverage it in any branch

Not sure if I understand it correctly. You mean we could use make generated-files instead switching between generated-files-release-next an make generated-files by allowing to pass the branch here in the form of ENV variable?
Something like KNATIVE_EVENTING_KAFKA_BROKER_BRANCH=release-next make generated-files ?

Note: This would need specifying the branch for all components, i.e. KNATIVE_SERVING_BRANCH=release-next KNATIVE_EVENTING_BRANCH=release-next KNATIVE_EVENTING_KAFKA_BROKER_BRANCH=release-next make generated-files

[creydr]

In this PR we would only install the release-next artifacts, when on the release-next branch. Otherwise the artifacts of the coresponding release-vX.Y branch will be installed (see

eventing-kafka-broker/openshift/e2e-common.sh

Lines 92 to 101 in 679967d

	if [ "$ekb_branch" = "release-next" ]; then
	export USE_RELEASE_NEXT="true"
	make generated-files-release-next
	else
	# use same eventing-core version as for EKB
	yq w --inplace "${operator_dir}/olm-catalog/serverless-operator/project.yaml" 'dependencies.eventing' "${ekb_tag}"
	yq w --inplace "${operator_dir}/olm-catalog/serverless-operator/project.yaml" 'dependencies.eventing_artifacts_branch' "${ekb_branch}"
	make generated-files
	fi

).

Anyhow we discussed that something like this would make more sense to have it directly in SO, so we don't need to repeat it in every repo. So closing this here