Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.11] [SRVKS-661][Backport] Support http1 full duplex per workload (#14568) #591

Conversation

skonto
Copy link

@skonto skonto commented Jan 17, 2024

What this PR does / why we need it:

Adds support for http1 full duplex, solves a related bug.

Which issue(s) this PR fixes:

JIRA: SRVKS-661

Does this PR needs for other branches:

YES but will do it manually as it creates a conflict.

Does this PR (patch) needs to update/drop in the future?:

JIRA: NONE

@skonto
Copy link
Author

skonto commented Jan 17, 2024

/test 414-images

@skonto
Copy link
Author

skonto commented Jan 17, 2024

It requires 1.21 on this branch too. Forgot about it.

time="2024-01-17T18:06:27Z" level=info msg="Not using native diff for overlay, this may cause degraded performance for building images: kernel has CONFIG_OVERLAY_FS_REDIRECT_DIR enabled"
I0117 18:06:27.533194       1 defaults.go:112] Defaulting to storage driver "overlay" with options [mountopt=metacopy=on].
Caching blobs under "/var/cache/blobs".

Pulling image image-registry.openshift-image-registry.svc:5000/ci-op-5jgw515c/pipeline@sha256:0bf4f011b1a0f5c46a52985e9d3620ad95e23ff0e7f31ef486f5245de3c8f6c1 ...
Trying to pull image-registry.openshift-image-registry.svc:5000/ci-op-5jgw515c/pipeline@sha256:0bf4f011b1a0f5c46a52985e9d3620ad95e23ff0e7f31ef486f5245de3c8f6c1...
Getting image source signatures
Copying blob sha256:432e4e3f3cfc751b6d41ae2e40684e3e505507481b5b37212c771db31919bb55
Copying blob sha256:2d473b07cdd5f0912cd6f1a703352c82b512407db6b05b43f2553732b55df3bc
Copying config sha256:1ddd6146e54d0049f053fd040fefb04419e22557613239735726a51dbbf393a4
Writing manifest to image destination

Pulling image openshift/origin-base ...
Resolving "openshift/origin-base" using unqualified-search registries (/var/run/configs/openshift.io/build-system/registries.conf)
Trying to pull registry.redhat.io/openshift/origin-base:latest...
Trying to pull registry.access.redhat.com/openshift/origin-base:latest...
Trying to pull quay.io/openshift/origin-base:latest...
Getting image source signatures
Copying blob sha256:d05880195e449233f9f09096dfce15933ebc2692a9567d45247297ccf27b051b
Copying blob sha256:d8190195889efb5333eeec18af9b6c82313edd4db62989bd3a357caca4f13f0e
Copying blob sha256:3f3118231add37174a666c1de8d517e6a1c134a905bad7325b33ae2a31c98d5a
Copying blob sha256:97da74cc6d8fa5d1634eb1760fd1da5c6048619c264c23e62d75f3bf6b8ef5c4
Copying blob sha256:aaa3af1143c99c95df2d90ad9d76986ecd73a163c3aa730b5187e091ce2fe2dd
Copying config sha256:43dfce8018508eef2ec642d4186f67dc2644d5a7e327b6786984556bc201a76b
Writing manifest to image destination
Adding transient rw bind mount for /run/secrets/rhsm
[1/2] STEP 1/4: FROM image-registry.openshift-image-registry.svc:5000/ci-op-5jgw515c/pipeline@sha256:0bf4f011b1a0f5c46a52985e9d3620ad95e23ff0e7f31ef486f5245de3c8f6c1 AS builder
Trying to pull image-registry.openshift-image-registry.svc:5000/ci-op-5jgw515c/pipeline@sha256:0bf4f011b1a0f5c46a52985e9d3620ad95e23ff0e7f31ef486f5245de3c8f6c1...
Getting image source signatures
Copying blob sha256:432e4e3f3cfc751b6d41ae2e40684e3e505507481b5b37212c771db31919bb55
Copying blob sha256:2d473b07cdd5f0912cd6f1a703352c82b512407db6b05b43f2553732b55df3bc
Copying config sha256:1ddd6146e54d0049f053fd040fefb04419e22557613239735726a51dbbf393a4
Writing manifest to image destination
[1/2] STEP 2/4: ENV "BUILD_LOGLEVEL"="0"
[1/2] STEP 3/4: COPY . .
[1/2] STEP 4/4: RUN make install test-install
for img in ./cmd/activator ./cmd/autoscaler ./cmd/autoscaler-hpa ./cmd/controller ./cmd/queue ./cmd/webhook ./vendor/knative.dev/pkg/apiextensions/storageversion/cmd/migrate; do \
	go install -tags="disable_gcp,disable_aws,disable_azure" $img ; \
done
# knative.dev/serving/pkg/activator/handler
pkg/activator/handler/handler.go:159:15: undefined: http.NewResponseController```

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac
@ReToCode
Copy link
Member

/retest

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

we still need the bump on S-O first.

@openshift-ci openshift-ci bot added the lgtm label Jan 19, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f2b8975 and 2 for PR HEAD 7e2eee7 in total

@skonto
Copy link
Author

skonto commented Jan 19, 2024

/test 414-images

@skonto
Copy link
Author

skonto commented Jan 19, 2024

Blocked on openshift-knative/serverless-operator#2451. Will do a PR for 1.12 as well.

@skonto
Copy link
Author

skonto commented Jan 22, 2024

/hold for investigating unit test being flaky knative#14806

@openshift-ci openshift-ci bot removed the lgtm label Jan 22, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2024
Copy link

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

/retest-required

@skonto
Copy link
Author

skonto commented Jan 23, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 3df6a63 into openshift-knative:release-v1.11 Jan 23, 2024
10 checks passed
openshift-merge-bot bot pushed a commit that referenced this pull request Jan 29, 2024
…rkload (knative#14568) (#591) (#605)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants