[RELEASE-1.12][SRVKS-831] Make route domain error specific (#15082) #685
Conversation
skonto
requested review from
ReToCode
and removed request for
mgencur and
alanfx
|
/retest |
* make route domain error specific * fixes * fix quote * move to errors.Is * lint
skonto
force-pushed
the
make_domain_error_specific
branch
from
8e2a995
to
78dd62d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/415-test-e2e-tls-aws-415 |
|
@skonto: Overrode contexts on behalf of skonto: ci/prow/415-test-e2e-tls-aws-415 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override "ci/prow/415-test-e2e-tls-aws-415" |
|
@ReToCode: Overrode contexts on behalf of ReToCode: ci/prow/415-test-e2e-tls-aws-415 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit 7da1b6d
into
openshift-knative:release-v1.12
make route domain error specific
fixes
fix quote
move to errors.Is
lint
What this PR does / why we need it:
Backport of knative#15082
Which issue(s) this PR fixes:
JIRA: SRVKS-831
Does this PR needs for other branches:
NONE
Does this PR (patch) needs to update/drop in the future?:
JIRA: NONE