Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 JS image boots properly now #21

Conversation

cardil
Copy link
Member

@cardil cardil commented Apr 14, 2023

After the #11 the JS image wasn't booting:

> @openshift/knative-showcase@main serve:only
> node src/index

node:internal/modules/cjs/loader:988
  throw err;
  ^

Error: Cannot find module 'git-describe'
Require stack:
- /opt/app-root/src/src/lib/project.js
- /opt/app-root/src/src/middleware/openapi.js
- /opt/app-root/src/src/app.js
- /opt/app-root/src/src/index.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Function.Module._load (node:internal/modules/cjs/loader:833:27)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/opt/app-root/src/src/lib/project.js:3:29)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Module.require (node:internal/modules/cjs/loader:1057:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/opt/app-root/src/src/lib/project.js',
    '/opt/app-root/src/src/middleware/openapi.js',
    '/opt/app-root/src/src/app.js',
    '/opt/app-root/src/src/index.js'
  ]
}
npm notice 
npm notice New major version of npm available! 8.19.2 -> 9.6.4
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
npm notice Run `npm install -g npm@9.6.4` to update!
npm notice

This PR fixes this, and adds tests to smoke test the images before push.

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Apr 14, 2023
@openshift-ci openshift-ci bot requested review from aliok and mgencur April 14, 2023 11:03
@cardil cardil force-pushed the bugfix/js-image-fail-boot branch 2 times, most recently from 10b25cc to 3a2d492 Compare April 14, 2023 11:45
@mgencur
Copy link

mgencur commented Apr 14, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2b0a547 into openshift-knative:latest Apr 14, 2023
@cardil cardil deleted the bugfix/js-image-fail-boot branch April 14, 2023 13:27
@cardil
Copy link
Member Author

cardil commented Apr 14, 2023

/cherry-pick release-0.7

@openshift-cherrypick-robot

@cardil: new pull request created: #23

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants