Added redfish for KVM option to install-config template #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @nsilla. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Starting dci-check-change job. |
|
lgtm but can you add the same to "install-config-virtualmedia.j2" to keep them in sync |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
1 similar comment
|
Starting dci-check-change job. |
|
|
|
Starting dci-check-change job. |
1 similar comment
|
Starting dci-check-change job. |
|
|
|
Starting dci-check-change job. |
1 similar comment
|
Starting dci-check-change job. |
|
1 similar comment
|
|
Starting dci-check-change job. |
1 similar comment
|
Starting dci-check-change job. |
|
1 similar comment
|
|
Starting dci-check-change job. |
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
|
Starting dci-check-change job. |
|
nsilla
added a commit
to nsilla/ansible-collection-redhatci-ocp
that referenced
this pull request
Nov 20, 2023
Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol. Sushy tools provides support for the redfish protocol for libvirt VMs. This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role. Depends-On: dci-labs/bos2-ci-config#72 Depends-On: openshift-kni/baremetal-deploy#975 Depends-On: redhat-partner-solutions/crucible#272 Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla
added a commit
to nsilla/ansible-collection-redhatci-ocp
that referenced
this pull request
Nov 20, 2023
Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol. Sushy tools provides support for the redfish protocol for libvirt VMs. This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role. Depends-On: dci-labs/bos2-ci-config#72 Depends-On: openshift-kni/baremetal-deploy#975 Depends-On: redhat-partner-solutions/crucible#272 Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla
added a commit
to nsilla/ansible-collection-redhatci-ocp
that referenced
this pull request
Dec 19, 2023
Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol. Sushy tools provides support for the redfish protocol for libvirt VMs. This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role. Depends-On: dci-labs/bos2-ci-config#72 Depends-On: openshift-kni/baremetal-deploy#975 Depends-On: redhat-partner-solutions/crucible#272 Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla
added a commit
to nsilla/ansible-collection-redhatci-ocp
that referenced
this pull request
Jan 9, 2024
Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol. Sushy tools provides support for the redfish protocol for libvirt VMs. This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role. Depends-On: dci-labs/bos2-ci-config#72 Depends-On: openshift-kni/baremetal-deploy#975 Depends-On: redhat-partner-solutions/crucible#272 Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla
added a commit
to nsilla/ansible-collection-redhatci-ocp
that referenced
this pull request
Feb 5, 2024
Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol. Sushy tools provides support for the redfish protocol for libvirt VMs. This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role. Depends-On: dci-labs/bos2-ci-config#72 Depends-On: openshift-kni/baremetal-deploy#975 Depends-On: redhat-partner-solutions/crucible#272 Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
nsilla
added a commit
to nsilla/ansible-collection-redhatci-ocp
that referenced
this pull request
Feb 9, 2024
Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol. Sushy tools provides support for the redfish protocol for libvirt VMs. This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role. Depends-On: dci-labs/bos2-ci-config#72 Depends-On: openshift-kni/baremetal-deploy#975 Depends-On: redhat-partner-solutions/crucible#272 Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently redfish is supported for HP and Dell systems, but none of
these vendors provide settings compatible with sushy-tools based virtual
BMCs. For instance, all the KVMs in the same hypervisor share the BMC
address, and are differentiated by the system ID, which is part of the
resource path.
This change extends the install-config and install-config-virtualmedia
templates to allow for sushy-tools based redfish vBMCs.
Type of change
Please select the appropriate options:
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist