Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename node-prep role to node_prep #987

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Rename node-prep role to node_prep #987

merged 2 commits into from
Oct 10, 2023

Conversation

tonyskapunk
Copy link
Contributor

Description

This role among install is expected to be moved to ansible collections. Ansible collections requires that roles include only underscores, i.e. hyphens are not allowed

https://docs.ansible.com/ansible/latest/collections_guide/collections_using_playbooks.html#using-collections-in-roles

Playbook names, like other collection resources, have a restricted set of valid characters. Names can contain only lowercase alphanumeric characters, plus _ and must start with an alpha character. The dash - character is not valid for playbook names in collections. Playbooks whose names contain invalid characters are not addressable: this is a limitation of the Python importer that is used to load collection resourc

Type of change

Please select the appropriate options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Will be tested in DCI to validate the renaming

Test Configuration:

  • Versions:
  • Hardware:

Checklist

  • I have performed a self-review of my own code
  • If a change is adding a feature, it should require a change to the README.md and the review should catch this.
  • If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
  • A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
  • PRs should not be merged unless positively reviewed.

@tonyskapunk
Rename node-prep role to node_prep
9439601 
This role among install is expected to be moved to ansible collections.
Ansible collections requires that roles include only underscores, i.e.
hyphens are not allowed
@openshift-ci openshift-ci bot added kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

Hi @tonyskapunk. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcibot
Copy link

dcibot commented Oct 3, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Oct 3, 2023

@dcibot
Copy link

dcibot commented Oct 3, 2023

@tonyskapunk
Copy link
Contributor Author

Ran a couple of tests by pointing to this PR

@tonyskapunk
Copy link
Contributor Author

check dallas ocp-4.13-vanilla

@dcibot
Copy link

dcibot commented Oct 9, 2023

@tonyskapunk
Copy link
Contributor Author

@derekhiggins I've completed the testing. On the last job it is validated that the symlink is valid for those cases where node-prep is used.

Please let me know if there is anything else needed in this change.

@derekhiggins
Copy link
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 55aa682 into openshift-kni:master Oct 10, 2023
6 checks passed
@tonyskapunk tonyskapunk deleted the rename_role branch October 10, 2023 13:32
mukrishn added a commit to redhat-performance/JetSki that referenced this pull request Sep 27, 2024
@mukrishn @dependabot
@iranzo @rabin-io @derekhiggins @rlopez133 @jlojosnegros @patrickeasters @p3ck @tonyskapunk @dollierp @abhatt-rh @rh-gvincent @manurodriguez @fredericlepied @fdaencarrh @radez @pierreblanc @nsilla @zhouhao3
upstream rebase and fixed hostname issue (#303)
348b396 
* build(deps): bump actions/checkout from 2.3.4 to 2.4.0 (openshift-kni#812)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.4...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): update ansible requirement from <4.7.0 to <4.9.0 (openshift-kni#813)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump technote-space/broken-link-checker-action

Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.9 to 2.2.10.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.9...v2.2.10)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/setup-python from 2.2.2 to 2.3.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2.2.2 to 2.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.2.2...v2.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 2.1.6 to 2.1.7

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <4.9.0 to <4.10.0 (openshift-kni#817)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump actions/setup-python from 2.3.0 to 2.3.1

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.3.0...v2.3.1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <4.10.0 to <5.1.0 (openshift-kni#819)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): update ansible requirement from <5.1.0 to <5.2.0 (openshift-kni#821)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update install-config.j2 template to support provisioningDHCPRange

Allow to set the provisioningDHCPRange if the prov_dhcp_range variable is set

* Add derekhiggins as an approver

The previous owners of this repository have moved
onto other things, I'll will be keeping things operating
until more permanent owners are identified.

* Update OWNERS_ALIASES (openshift-kni#820)

* build(deps): bump technote-space/broken-link-checker-action (openshift-kni#825)

Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.10 to 2.2.11.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.10...v2.2.11)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): update ansible requirement from <5.2.0 to <5.3.0 (openshift-kni#827)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add defaults for async deployment timeouts (openshift-kni#809)

Set defaults for increase_bootstrap_timeout and increase_install_timeout
vars

* build(deps): bump technote-space/broken-link-checker-action (openshift-kni#829)

Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.11 to 2.2.12.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.11...v2.2.12)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Optional support for irmc BMC (openshift-kni#826)

This allows for irmc BMC to be used in the install-config.yaml.

* Use rhcos json stream on 4.8+ (openshift-kni#831)

* Use openshift-baremetal-install coreos print-stream-json to obtain RHCOS image paths

- Starting in 4.8 the installer contains pinned images of RHCOS in the binary
- Format of the stream is different so its parsing differs to older versions

* Use correct conditional on rhcos facts

* Use proper rhcos key

* Add Optional support for FIPS enabled clusters (openshift-kni#841)

Signed-off-by: Denis Ollier <dollierp@redhat.com>

* build(deps): bump technote-space/broken-link-checker-action

Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.12 to 2.3.1.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.12...v2.3.1)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/stale from 4 to 6

Bumps [actions/stale](https://github.com/actions/stale) from 4 to 6.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v4...v6)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 2.1.7 to 3.0.11

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.7 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2.1.7...v3.0.11)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Remove reference to openstack baremetal and update it to baremetal

* build(deps): update ansible requirement from <5.3.0 to <7.2.0

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/setup-python from 2.3.1 to 4.3.1

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2.3.1 to 4.3.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.3.1...v4.3.1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/checkout from 2.4.0 to 3.2.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3.2.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.4.0...v3.2.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Adjust owners and aliases

* Delete greetings.yml

* Update jekyll.yml

Lock to Major

* Delete ansible-lint.yml

* Prefix temp directories with baremetal-deploy to avoid permission issues

baremetal-deploy download OpenShift binaries in a /tmp/ansible.xxxx folder using the tempfile ansible module.
baremetal-deploy also remove all /tmp/ansible.xxxx folders before downloading those binaries.
cf https://github.com/openshift-kni/baremetal-deploy/blob/47e20e26595fcf7696d7a6414cf4acb2af683a6e/ansible-ipi-install/roles/installer/tasks/10_get_oc.yml
This is weird to me, but I may miss some context here.

The problem is baremetal-deploy is used by other ansible code that may use the tempfile ansible module with a user different than kni.
The deletion of the folders will fail because of permission issue.

This patch prefix the temp folder with baremetal-deploy. Binaries will be downloaded in /tmp/baremetal-deploy.xxxx temp folder.
A better approach may have been to delete those temp folder after usage, instead of before, and delete only the ones created.

* Add support to pass NMstate vars in install-config

This patch allows to include NMstate network settings
in the install-config.yaml file and setup custom
networking at day1

* fix name of fact for worker when using raw config

* fix name of fact for worker when using file config

* add options to pass network varibles per node

this allows to pass files with NMstate settings
and have the option to include jinja expressions
to be replaced with variable content from the inventory

* fix block code of inventory example

* fix template verification with stat conditions

* delegate NM template checking to ansible controller

* Update test container image

Update this image to something that builds and is
more recent then Fedora31/Go1.13.5

* Fix CI

- use latest versions of actions in .github/workflows/ansible-lint.yml
- fix some reports from ansible-lint

* Support externalMACAddress for bootstrapVM (openshift-kni#911)

* Support externalMACAddress for bootstrapVM

Add the ability to set the external Mac address for the bootstrap
VM in the install-config.j2 template

* Changing the example in the doc

Put an example more generic to avoid copy paste issue

* Allow passing a custom release_url

When release_url is defined do not set the default release URLs

* build(deps): bump actions/setup-python from 4.3.1 to 4.4.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.3.1...v4.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 3.0.11 to 3.2.2

Bumps [actions/cache](https://github.com/actions/cache) from 3.0.11 to 3.2.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.11...v3.2.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/stale from 6 to 7

Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v6...v7)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/checkout from 3.2.0 to 3.3.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.2.0...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 3.2.2 to 3.2.3

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.2.3.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.2...v3.2.3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Adjust asciidoctor version

* Adjust asciidoctor version syntax

* Adjust jekyll-ascidoc instead of asciidoctor

* Adjust jekyll version

* Adjust sass-converter version

* Remove trailing comma

* build(deps): bump actions/setup-python from 4.4.0 to 4.5.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.4.0...v4.5.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 3.2.3 to 3.2.4

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.3 to 3.2.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.3...v3.2.4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 3.2.4 to 3.2.5

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.4...v3.2.5)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <7.2.0 to <7.3.0

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 3.2.5 to 3.2.6

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.5 to 3.2.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.5...v3.2.6)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <7.3.0 to <7.4.0 (openshift-kni#948)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Removing Ansible as a package dep.

You can't run ansible without is already being installed. There are some
packaging dep conflicts in installing ansible from RPMs on RHEL in the
shared labs. This requirement will always hit that problem. Since
ansible has to be already installed to get to this point there's no
reason for it to be required here. If it's been installed by pip instead
of RPM then the deploy can't continue.

* build(deps): bump actions/checkout from 3.3.0 to 3.4.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/stale from 7 to 8

Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/cache from 3.2.6 to 3.3.1

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.6 to 3.3.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.6...v3.3.1)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add retries to get the ocp client

* build(deps): bump actions/checkout from 3.4.0 to 3.5.1

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.4.0 to 3.5.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.4.0...v3.5.1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add support to dualstack vips starting in 4.12 (openshift-kni#953)

This patch allows to specify IPv4 and IPv6 VIPs
for Ingress and API using dualstack_vips boolean.
Validations are included and if not specify it,
then it defaults to old variables to specify a
single VIP for Ingress and API.

* build(deps): bump actions/checkout from 3.5.1 to 3.5.2

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.5.1...v3.5.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <7.4.0 to <7.5.0

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add support for wwnVendorExtension & wwnWithExtension as disk hints (openshift-kni#960)

* Add wwnVendorExtension, wwnWithExtension

to roothint_list

* Update install-config templates

Add quotes around disk hint value,
in case the value in format of "0x1234"
which Ansible will convert to integer

Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>

---------

Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>

* Add missing quotes for drive hint in workers group (openshift-kni#961)

* build(deps): bump actions/setup-python from 4.5.0 to 4.6.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.5.0...v4.6.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <7.5.0 to <7.6.0

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): update ansible requirement from <7.6.0 to <7.7.0

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/setup-python from 4.6.0 to 4.6.1

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.6.0...v4.6.1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Introduce the use of imageDigestSources (openshift-kni#965)

The imageContentSources is being deprecated in the openshift-installer
and imageDigestSources is replacing it.
Allow the use of imageDigestSources when the disconnected registry is created.
Updating docs to reflect the use of each CR depending on the OCP version

* build(deps): bump actions/checkout from 3.5.2 to 3.5.3

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add externalMACAddress in virtualmedia template (openshift-kni#974)

Bringing parity with non-virtualmedia installs by adding
externalMACAddress in the virtualmedia template, allowing
libvirt to use a specific hwaddr in the provisioner host.
Limiting the use of provisioningHostIP in virtualmedia only
in the supported (4.6) version

Signed-off-by: Tony Garcia <tonyg@redhat.com>

* Change the RHCOS image cache container public registry (openshift-kni#978)

* Change the RHCOS image cache container

registry.centos.org seems to be done or unavailable.
Changing from registry.centos.org to quay.io and add the ability
to change it if needed.

* Change registry.centos.org in the documentation

Change the documentation to replace registry.centos.org to quay.io

* Allowing status code 301 when verifying the internet connectivity (openshift-kni#986)

Currently, when checking the connectivity to the Internet, an HTTP query
is set against https://www.redhat.com.

This address will respond with a 301 status code redirecting the client
to https://www.redhat.com/en.

The URI ansible module is able to follow redirects so, if everything is
OK, the query shour result in either a 200 status code if the server is
reachable, or a -1 if it's not. In this later scenario, a disconnected
environment is assumed.

The problem is in some labs the web server gets into an infinite
redirect loop, so the resulting status code would be 301.

This change allows for this status code to be accepted as evidence that
the Red Hat web site was reached and, therefore, the network has
Internet access.

* Added support for redfish for KVM hosts

Currently redfish is supported for HP and Dell systems, but none of
these vendors provide settings compatible with sushy-tools based virtual
BMCs. For instance, all the KVMs in the same hypervisor share the BMC
address, and are differentiated by the system ID, which is part of the
resource path.

This change extends the install-config and install-config-virtualmedia
templates to allow for sushy-tools based redfish vBMCs.

* Fix task Get URL of host providing the webserver (openshift-kni#988)

Fix the issue "'in <string>' requires string as left operand, not int"
at the task "Get URL of host providing the webserver"

* Rename node-prep role to node_prep (openshift-kni#987)

* Rename node-prep role to node_prep

This role among install is expected to be moved to ansible collections.
Ansible collections requires that roles include only underscores, i.e.
hyphens are not allowed

* Keep a symlink to the old repo name

* install-config.j2: support disableCertificateVerification for irmc (openshift-kni#983)

Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>

* Use collections (openshift-kni#1000)

* Use collections

Move to use collections, this is to conclude the migration of roles to
the redhatci.ocp collection.
Add the steps and changes required to consume collections.
Remove the submodule for containers.podman and use a newer version.
Update the docs to make clear the playbook is using collections.

* Install collection dependency in GH workflow

* updated playbook to use collections

* fixing playbook

* reading collection path custom ign file

* r640 servers shift to rack f18

* custom network config was not set

* fixed lab dns problem

* corrected variable dict

* scale worker patch

* updated r650 nic naming

* updated public vlan nic for fc640

* removed rdo packages that are not required in rhel9

* fixed jinja templating issue

* changed scale lab api endpoint

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Denis Ollier <dollierp@redhat.com>
Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>
Signed-off-by: Tony Garcia <tonyg@redhat.com>
Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
Co-authored-by: Rabin Yasharzadehe <rabin@rabin.io>
Co-authored-by: Derek Higgins <derekh@redhat.com>
Co-authored-by: Roger Lopez <rlopez@redhat.com>
Co-authored-by: Jose Luis Ojosnegros Manchon <jojosneg@redhat.com>
Co-authored-by: Patrick Easters <patrick@patrickeasters.com>
Co-authored-by: Bill Peck <bpeck@redhat.com>
Co-authored-by: Tony Garcia <tonyskapunk@users.noreply.github.com>
Co-authored-by: Denis Ollier <dollierp@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Guillaume Vincent <gvincent@redhat.com>
Co-authored-by: Manuel Rodriguez <manu.rodri.hernan@gmail.com>
Co-authored-by: Manuel Rodriguez <manuel.rodriguez@redhat.com>
Co-authored-by: Frederic Lepied <flepied@redhat.com>
Co-authored-by: fdaencar <64908537+fdaencarrh@users.noreply.github.com>
Co-authored-by: Tony Garcia <tonyg@redhat.com>
Co-authored-by: Dan Radez <dradez@redhat.com>
Co-authored-by: Pierre Blanc <pblanc@redhat.com>
Co-authored-by: Rabin Yasharzadehe <ryasharz@redhat.com>
Co-authored-by: Nacho Silla <84012405+nsilla@users.noreply.github.com>
Co-authored-by: Nacho Silla <nsilla@redhat.com>
Co-authored-by: Zhou Hao <zhouhao@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@rlopez133 rlopez133 Awaiting requested review from rlopez133

Assignees

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyskapunk @dcibot @derekhiggins