cnf-tests: add tap device tests #725
Conversation
mmirecki
changed the title
|
/retest |
|
/retest |
1 similar comment
|
/retest |
There was a problem hiding this comment.
Thanks for the PR I leave some comments but the main issue in the PR is that I was not able to find the place where you configure the sriovNetworkNodePolicy to mount the vhost-net device.
you can please also add a check before you start the dpdk application that /dev/vhost-net exist inside the container?
| if err != nil { | ||
| return "", err | ||
| } | ||
| macLine := strings.Trim(strings.Split(getMacOutput.String(), "\n")[1], " ") |
There was a problem hiding this comment.
please check the len here before you do the [1] to be sure we are not going to fly
|
Waiting for: k8snetworkplumbingwg/sriov-network-device-plugin#394 |
openshift-ci
bot
added
the
needs-rebase
|
@mmirecki everything is merged in the sriov operator, can you please rebase and check this PR. Also please remove the mknod capability and the creation of the tun device. |
| sleep INF | ||
| `, dpdkResourceName, testpmdCommand, dpdkResourceName, runningTime)}, | ||
| command, | ||
| }, | ||
| SecurityContext: &corev1.SecurityContext{ | ||
| RunAsUser: pointer.Int64Ptr(0), | ||
| Capabilities: &corev1.Capabilities{ | ||
| // Enable NET_RAW is required by mellanox nics as they are using the netdevice driver |
There was a problem hiding this comment.
can you move the comment above this line (capabilities := []corev1.Capability{"IPC_LOCK", "SYS_RESOURCE", "NET_RAW"})
| @@ -1397,3 +1506,42 @@ func CleanSriov() { | |||
| } | |||
| sriov.WaitStable(sriovclient) | |||
| } | |||
|
|
|||
| func getDeviceMac(pod *corev1.Pod, device string) (string, error) { | |||
There was a problem hiding this comment.
no need for this function lets just static allocate the mac addresses
openshift-ci
bot
added
needs-rebase
|
Hi @mmirecki please take a look on the CI lane |
| @@ -74,6 +77,8 @@ var ( | |||
| intelVendorID = "8086" | |||
|
|
|||
| sriovNicsTable []TableEntry | |||
|
|
|||
| dpdkWorkloadMac = "60:00:00:00:00:01" | |||
There was a problem hiding this comment.
nit: I think this can be a const
| }, 2*time.Minute, 1*time.Second).Should(ContainSubstring(LOG_ENTRY), | ||
| "Cannot find accumulated statistics") | ||
| By("Checking the tx output from the client DPDK application") | ||
| checkTxOnly(out) |
There was a problem hiding this comment.
can you please also check the tap side here
| Expect(len(lines)).To(BeNumerically(">=", 3)) | ||
| for i, line := range lines { | ||
| if strings.Contains(line, "NIC statistics for port") { | ||
| if getNumberOfPackets(lines[i+1], "RX") > 0 { |
There was a problem hiding this comment.
should you check here if i+1 exist?
| return out | ||
| }, 8*time.Minute, 1*time.Second).Should(ContainSubstring("NIC statistics for port"), | ||
| "Cannot find accumulated statistics") | ||
| checkRx(out) |
There was a problem hiding this comment.
should the function be checkRxOnly like checkTxOnly
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmirecki, SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
No description provided.