Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keda pkg: TriggerAuthentication object handler added #449

Merged
merged 6 commits into from
Jun 11, 2024
Merged

keda pkg: TriggerAuthentication object handler added #449

merged 6 commits into from
Jun 11, 2024

Conversation

elenagerman
Copy link
Contributor

No description provided.

@elenagerman elenagerman mentioned this pull request May 31, 2024
Merged
@elenagerman elenagerman force-pushed the ta branch 3 times, most recently from 2a2b7e0 to be1a993 Compare June 3, 2024 16:29
kononovn
kononovn requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just 3 minor comments to fix.

@elenagerman elenagerman requested a review from kononovn June 5, 2024 14:34
@elenagerman elenagerman force-pushed the ta branch 2 times, most recently from fbc9a32 to ec361e4 Compare June 5, 2024 15:15
kononovn
kononovn requested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix few comments

@elenagerman elenagerman force-pushed the ta branch 3 times, most recently from 9b5adf9 to 7b9bb7f Compare June 6, 2024 18:20
@elenagerman elenagerman requested a review from kononovn June 6, 2024 18:20
@elenagerman
Copy link
Contributor Author

@trewest @kononovn @achuzhoy @cdvultur PTAL

kononovn
kononovn reviewed Jun 10, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
kononovn
kononovn requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr looks good, no additional comments. I'll add lgtm after re-base.

@elenagerman elenagerman requested a review from kononovn June 10, 2024 19:37
kononovn
kononovn reviewed Jun 11, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
kononovn
kononovn requested changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 comment to fix

@elenagerman elenagerman requested a review from kononovn June 11, 2024 14:19
kononovn
kononovn approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cdvultur
cdvultur approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@cdvultur cdvultur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cdvultur cdvultur merged commit 9e4045b into openshift-kni:main Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdvultur cdvultur cdvultur approved these changes

@kononovn kononovn kononovn approved these changes

@trewest trewest Awaiting requested review from trewest trewest is a code owner

@achuzhoy achuzhoy Awaiting requested review from achuzhoy achuzhoy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elenagerman @kononovn @cdvultur