Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add pull and deletes plus tests to storageclass #466

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

klaskosk
Copy link
Collaborator

@klaskosk klaskosk commented Jun 6, 2024

Added a PullClass function to the storage package; added Delete, DeleteAndWait, and WaitUntilDeleted methods to ClassBuilder; and added unit tests for all of the functions in storageclass.go.

Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just few changes are needed.

@klaskosk
Copy link
Collaborator Author

@kononovn Updated the test, although there's no check for a nil client in NewClassBuilder since the apiClient field hasn't been narrowed so it would be redundant with validate

@kononovn
Copy link
Collaborator

@kononovn Updated the test, although there's no check for a nil client in NewClassBuilder since the apiClient field hasn't been narrowed so it would be redundant with validate

I know just to make it more consistent can you add to NewBuilder following condition?

if apiClient == nil {

Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comment above.

@klaskosk klaskosk force-pushed the sc-pull branch 2 times, most recently from 0af9ad5 to f16b3d1 Compare June 10, 2024 18:43
kononovn
kononovn previously approved these changes Jun 10, 2024
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Added a PullClass function to the storage package; added Delete, DeleteAndWait, and WaitUntilDeleted methods to ClassBuilder; and added unit tests for all of the functions in `storageclass.go`.
Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trewest trewest merged commit 05b2dc7 into openshift-kni:main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants