Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assisted-service: Add imageStorage to the service configuration #1365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

assisted-service: Add imageStorage to the service configuration #1365

wants to merge 1 commit into from

Conversation

mkowalski
Copy link
Member

With openshift/assisted-service#3067 we have
introduced an imageStorage configuration option that needs to be set
in the AgentServiceConfig for Infrastructure Operator.

This PR adds the configuration, so that make assisted target can
deploy the operator seamlessly.

/cc @mresvanis

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2022

@mkowalski: GitHub didn't allow me to request PR reviews from the following users: mresvanis.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

With openshift/assisted-service#3067 we have
introduced an imageStorage configuration option that needs to be set
in the AgentServiceConfig for Infrastructure Operator.

This PR adds the configuration, so that make assisted target can
deploy the operator seamlessly.

/cc @mresvanis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Member Author

#1364 is needed for this PR to restore a proper functionality of make assisted

@mkowalski
Copy link
Member Author

/cc @flaper87

@openshift-ci openshift-ci bot requested a review from flaper87 March 16, 2022 16:05
@flaper87
Copy link
Contributor

/lgtm

@flaper87
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@mkowalski
Copy link
Member Author

/retest

@mkowalski
Copy link
Member Author

/retest-required

@mkowalski mkowalski force-pushed the assisted-ASC-change branch from 0ae5b8c to aa139d5 Compare April 27, 2022 09:20
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@hardys
Copy link

hardys commented Jun 15, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@hardys
Copy link

hardys commented Jun 15, 2022

/retest

1 similar comment
@elfosardo
Copy link
Member

/retest

@mkowalski mkowalski force-pushed the assisted-ASC-change branch from aa139d5 to 3d4c5b6 Compare August 24, 2022 15:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@mkowalski
Copy link
Member Author

/retest-required

@mkowalski
assisted-service: Add imageStorage to the service configuration
9dcc3cb 
With openshift/assisted-service#3067 we have
introduced an `imageStorage` configuration option that needs to be set
in the AgentServiceConfig for Infrastructure Operator.

This PR adds the configuration, so that `make assisted` target can
deploy the operator seamlessly.
@mkowalski mkowalski force-pushed the assisted-ASC-change branch from 3d4c5b6 to 9dcc3cb Compare December 6, 2022 09:51
@dtantsur
Copy link
Member

dtantsur commented Dec 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@dtantsur
Copy link
Member

dtantsur commented Mar 5, 2024

/retest

@dtantsur dtantsur removed their assignment Jun 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 13, 2024

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-proxy-ipv6 aa139d5 link false /test e2e-metal-ipi-proxy-ipv6
ci/prow/e2e-metal-ipi-proxy-ipv4 aa139d5 link false /test e2e-metal-ipi-proxy-ipv4
ci/prow/e2e-metal-ipi 3d4c5b6 link true /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 9dcc3cb link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-virtualmedia 9dcc3cb link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 9dcc3cb link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ipv4 9dcc3cb link unknown /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaper87 flaper87 flaper87 approved these changes

Assignees

@flaper87 flaper87

@hardys hardys

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkowalski @flaper87 @hardys @elfosardo @dtantsur