Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-5952: Server name inference for regionalized OCM redirects #958

Merged
merged 1 commit into from
May 29, 2024
Merged

OCM-5952: Server name inference for regionalized OCM redirects #958

merged 1 commit into from
May 29, 2024

Conversation

tylercreller
Copy link
Member

@tylercreller tylercreller commented May 28, 2024 •
edited
Loading

  • Allow go tls to infer the ServerName from host address to enable redirects with TLS

See https://github.com/golang/go/blob/master/src/crypto/tls/tls.go#L148-L155

@macgregor
Copy link

lgtm, thanks for driving this home

macgregor
macgregor approved these changes May 29, 2024
View reviewed changes
Copy link

@macgregor macgregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rawsyntax rawsyntax merged commit 15e90bd into openshift-online:main May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macgregor macgregor macgregor approved these changes

@rawsyntax rawsyntax rawsyntax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylercreller @macgregor @rawsyntax