This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Option --url is not mandatory
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent patch we replaced `os.Exit(...)` with the Cobra error handling mechanism. A side effect of that change is that the `--url` option was marked as mandatory. This makes the application fail if it isn't explicity used even if it has a default value. This patch changes the application so that it isn't mandatory. Instead we just check that it isn't empty. Related: #61 Signed-off-by: Juan Hernandez <jhernand@redhat.com>
|
FYI: @cblecker |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent patch we replaced
os.Exit(...)with the Cobra errorhandling mechanism. A side effect of that change is that the
--urloption was marked as mandatory. This makes the application fail if it
isn't explicity used even if it has a default value. This patch changes
the application so that it isn't mandatory. Instead we just check that
it isn't empty.
Related: #61