Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow workspace to be configured when deploying ckcp #309

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Allow workspace to be configured when deploying ckcp #309

merged 1 commit into from
Nov 4, 2022

Conversation

Roming22
Copy link
Contributor

The workspace in which the service is deployed can now be configured by changing the kcp.workspace value in config/config.yaml.

The structure of the config.yaml file has been modified to improve readability by grouping values together when possible.

Signed-off-by: Romain Arnaud rarnaud@redhat.com

@openshift-ci openshift-ci bot requested review from fgiloux and Mo3m3n October 19, 2022 22:37
bnallapeta
bnallapeta reviewed Oct 20, 2022
View reviewed changes
config/config.yaml Outdated Show resolved Hide resolved
@Roming22
Copy link
Contributor Author

/retest

1 similar comment
@Roming22
Copy link
Contributor Author

/retest

@Roming22 Roming22 mentioned this pull request Oct 26, 2022
Closed
@Roming22
Allow workspace to be configured when deploying ckcp
418ed34 
The workspace in which the service is deployed can now be configured
by changing the kcp.workspace value in config/config.yaml.

The structure of the config.yaml file has been modified to improve
readability by grouping values together when possible.

Signed-off-by: Romain Arnaud <rarnaud@redhat.com>
@Roming22
Copy link
Contributor Author

Roming22 commented Nov 3, 2022

@xinredhat I can't reproduce the error on plnsvc-ckcp-test in my dev env using a cluster-bot hypershift cluster. I tried to access the test cluster, but while I can login, I don't seem to have the rights to see anything. Could you please have a look and help me troubleshoot the issue?

bnallapeta
bnallapeta approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@bnallapeta bnallapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bnallapeta
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bnallapeta, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Roming22,bnallapeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bnallapeta
Copy link
Contributor

@Roming22 the ckcp-test error was a flaky error which I too have faced earlier. Triggered a retest and looks to be good. Merging the PR.

@bnallapeta bnallapeta merged commit 8af93e5 into openshift-pipelines:main Nov 4, 2022
@Roming22 Roming22 deleted the ckcp-flags branch November 8, 2022 17:39
Roming22 pushed a commit that referenced this pull request Dec 19, 2022
@Michkov
Merge pull request #309 from Michkov/add-e2e-namespace
174de2b 
Add build-templates-e2e namespace for test execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnallapeta bnallapeta bnallapeta approved these changes

@fgiloux fgiloux Awaiting requested review from fgiloux

@Mo3m3n Mo3m3n Awaiting requested review from Mo3m3n

Assignees

@bnallapeta bnallapeta

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Roming22 @bnallapeta @Mo3m3n @openshift-merge-robot