Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified the dockerfile to support power server #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

modified the dockerfile to support power server #5

wants to merge 4 commits into from

Conversation

prashanthhat
Copy link

I have modified the dockerfile to support the power server

@akostadinov
Copy link
Contributor

@wzheng1 , any objections to merge?

@wzheng1
Copy link
Contributor

wzheng1 commented Mar 31, 2020

sorry, I cannot agree to get it merged. Since registry.redhat.io needs auth, if use the image directly, user needs to create pull secret under project and link to builder SA. @prashanthhat has talked to me, I have provided him another way to work with this image, so I think this pr should be closed.

@wzheng1
Copy link
Contributor

wzheng1 commented Apr 1, 2020

@prashanthhat I am afraid this change also cannot get merged. The way I told about using Openshift imagestream not working?

@akostadinov
Copy link
Contributor

Ok, @prashanthhat , are you ok with the other method?

btw I'm curious what is required for an image to be power compatible? What conditions should be met?

@prashanthhat
Copy link
Author

@akostadinov @wzheng1 I provide the redhat registry credentials for the image as a pullsecret with Serviceaccount and mentioned it build config it has worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prashanthhat @akostadinov @wzheng1