Skip to content

Commit

Permalink
operator/ingress: make .spec.endpointPublishingStrategy.type required
Browse files Browse the repository at this point in the history
The `.spec.endpointPublishingStrategy.type` is intended to be required (and
that's how the field is persisted in 4.1). In the operator.openshift.io group,
fields are optional by default[1]. Use an explicit marker to maintain
compatibility.

[1] https://github.com/openshift/api/blob/master/operator/v1/doc.go
  • Loading branch information
ironcladlou committed Sep 25, 2019
1 parent f6c477b commit ac32a08
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions operator/v1/types_ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ type EndpointPublishingStrategy struct {
// networking, and is not explicitly published. The user must manually publish
// the ingress controller.
// +unionDiscriminator
// +kubebuilder:validation:Required
// +required
Type EndpointPublishingStrategyType `json:"type"`

// loadBalancer holds parameters for the load balancer. Present only if
Expand Down

0 comments on commit ac32a08

Please sign in to comment.