Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE - Upgrade assisted-service to latest version #163

Closed
wants to merge 1 commit into from

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Feb 8, 2021

Had to also add a bunch of replace directives, see this for more info: golang/go#30354

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Feb 8, 2021

/cc @filanov

@filanov
Copy link
Contributor

filanov commented Feb 8, 2021

@carbonin maybe we can start with sub modules in assisted service instead of hive?

@omertuc
Copy link
Contributor Author

omertuc commented Feb 8, 2021

/hold

This doesn't work. Still a lot of conflicts

@omertuc omertuc closed this Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@omertuc omertuc reopened this Feb 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2021

@omertuc: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit-test 63816aa link /test unit-test
ci/prow/lint 63816aa link /test lint
ci/prow/images 63816aa link /test images
ci/prow/e2e-metal-assisted 63816aa link /test e2e-metal-assisted
ci/prow/e2e-metal-assisted-onprem 63816aa link /test e2e-metal-assisted-onprem

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@carbonin
Copy link
Member

carbonin commented Feb 8, 2021

Maybe, what pieces of the service is the agent depending on?

@filanov
Copy link
Contributor

filanov commented Feb 8, 2021

Maybe, what pieces of the service is the agent depending on?

The auto generated parts.

github.com/openshift/assisted-service/client/installer
github.com/openshift/assisted-service/models

@carbonin
Copy link
Member

carbonin commented Feb 8, 2021

Got it:

$ git grep github.com/openshift/assisted-service | cut -d: -f3 | sort | uniq
	"github.com/openshift/assisted-service/client"
	"github.com/openshift/assisted-service/client/installer"
	"github.com/openshift/assisted-service/models"
	"github.com/openshift/assisted-service/pkg/auth"
	"github.com/openshift/assisted-service/pkg/requestid"

@carbonin
Copy link
Member

carbonin commented Feb 8, 2021

Yeah, I'll give it a shot today

@openshift-ci-robot
Copy link

@omertuc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Feb 10, 2021

Irrelevant

@omertuc omertuc closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants