-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-3580 Can't set requested hostname for SNO #166
Conversation
Get the host ignition and merge it with the single node ignition created by bootkube
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
} | ||
// TODO: update this once we can get the full host specific overrides we have in the ignition | ||
// Remove the Config part since we only want the rest of the overrides | ||
hostConfig.Ignition.Config = config_31_types.IgnitionConfig{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
func ParseIgnitionFile(path string) (*config_31_types.Config, error) { | ||
configBytes, err := ioutil.ReadFile(path) | ||
if err != nil { | ||
return nil, errors.Errorf("error reading file %s: %v", path, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use errors.Wrapf
?
Does %v
on error give some extra data?
@eranco74: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Get the host ignition and merge it with the single node ignition created by bootkube.
Adding UT...