Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-3580 Can't set requested hostname for SNO #166

Closed
wants to merge 1 commit into from

Conversation

eranco74
Copy link
Contributor

Get the host ignition and merge it with the single node ignition created by bootkube.
Adding UT...

Get the host ignition and merge it with the single node ignition created by bootkube
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
}
// TODO: update this once we can get the full host specific overrides we have in the ignition
// Remove the Config part since we only want the rest of the overrides
hostConfig.Ignition.Config = config_31_types.IgnitionConfig{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

func ParseIgnitionFile(path string) (*config_31_types.Config, error) {
configBytes, err := ioutil.ReadFile(path)
if err != nil {
return nil, errors.Errorf("error reading file %s: %v", path, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use errors.Wrapf?
Does %v on error give some extra data?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2021
@openshift-ci-robot
Copy link

@eranco74: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants