[release-ocm-2.6] OCPBUGS-1482: Don't override schedulableMasters unnecessarily #4445
Conversation
When generating the Ignition files, the installer already sets schdulableMasters to true when there are no worker nodes (i.e. in the SNO and compact cluster topologies. (See openshift/installer#2004) Therefore it is unnecessary to override it here (though it may be preferred to avoid a warning log from the installer). Since openshift/installer#6247, attempting to override the schedulableMasters setting causes installation to fail, because there are two manifests of the same type and name that conflict. Since we don't need to set this override when the installer would already do it, avoid doing so and triggering the error when the value is determined by the number of hosts rather than explicitly set by the user. The conflict still needs to be resolved so that the user can enable schedulableMasters, but this at least allows the SNO and compact topologies to install OpenShift 4.12 again. This partially reverts commit c45f369.
|
@openshift-cherrypick-robot: An error was encountered updating cherry-pick bug in Jira: Created cherrypick Jira Issue OCPBUGS-1778, but encountered error updating target version for bug OCPBUGS-1778 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
customfield_12319940 - Version name 'rhacm-2.6' is not valid: request failed. Please analyze the request body for more details. Status code: 400:
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.6 #4445 +/- ##
================================================
Coverage 65.65% 65.65%
================================================
Files 189 189
Lines 26566 26566
================================================
Hits 17442 17442
Misses 7521 7521
Partials 1603 1603
|
|
/test e2e-ai-operator-ztp |
|
/override ci/prow/e2e-ai-operator-ztp-disconnected |
|
@filanov: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-ai-operator-ztp-disconnected |
|
@filanov: Overrode contexts on behalf of filanov: ci/prow/e2e-ai-operator-ztp-disconnected In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
filanov
added
the
bugzilla/valid-bug
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1482 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-ocm-2.5 |
|
@flaper87: #4445 failed to apply on top of branch "release-ocm-2.5": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4414
/assign filanov