[OSD-13681] Added a prefix 'g' to handle leading zeroes in CSV version #373
Conversation
|
Nice plan! This strategy may also fix the situation where a short hash happens to be all numeric and is thus interpreted as a number rather than a string. Not sure if this delta gets all the way down there. |
Co-authored-by: Michael Shen <mishen@umich.edu>
|
@aliceh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliceh, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
tide/merge-method-squash
In this commit, I added a prefix of 'g' to the hash to handle leading zeroes in CSV version, which was breaking OLM.
This is a convention used in other places. For example:
machine-api-operator ran into this https://bugzilla.redhat.com/show_bug.cgi?id=2015188 and fixed this by prepending a "g" for git I guess openshift-eng/doozer#527.
https://issues.redhat.com/browse/OSD-13681