Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Kube 1.16 #131

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Update to Kube 1.16 #131

merged 3 commits into from
Oct 2, 2019

Conversation

ironcladlou
Copy link
Contributor

No description provided.

ironcladlou
ironcladlou commented Oct 2, 2019
View reviewed changes
manifests/0000_70_dns-operator_00-custom-resource-definition.yaml
type: object
type: array
required:
- clusterIP
- clusterDomain
Copy link
Contributor Author

@ironcladlou ironcladlou Oct 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix depends on openshift/api#455

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 2, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
ironcladlou
ironcladlou commented Oct 2, 2019
View reviewed changes
manifests/0000_70_dns-operator_00-custom-resource-definition.yaml
Comment on lines -431 to -433
required:
- type
- status
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as openshift/cluster-ingress-operator#301 (comment) (openshift/api#445)

@ironcladlou
Copy link
Contributor Author

@Miciah this is ready for review, PTAL

@Miciah
Copy link
Contributor

Miciah commented Oct 2, 2019

/lgtm
We can regenerate in a follow-up PR once openshift/api#445 and openshift/api#455 are merged.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ironcladlou
Copy link
Contributor Author

@Miciah

We can regenerate in a follow-up PR once openshift/api#445 and openshift/api#455 are merged.

openshift/api#455 is already incorporated (fd88612#diff-994cc907b223d50dacb1ba617054962cR81)

@Miciah
Copy link
Contributor

Miciah commented Oct 2, 2019

You must have pushed an update between when I loaded the page and when I posted /lgtm. GitHub is scary.

@openshift-merge-robot openshift-merge-robot merged commit 89eec35 into openshift:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ironcladlou @Miciah @openshift-ci-robot @openshift-merge-robot