Bug 1833329: Add support for RemovePodsHavingTooManyRestarts strategy #108
Conversation
|
/cc @ingvagabund |
openshift-ci-robot
added
the
approved
| @@ -177,7 +178,7 @@ func generateConfigMapString(requestedStrategies []deschedulerv1beta1.Strategy) | |||
| if err != nil { | |||
| return "", err | |||
| } | |||
| switch param.Name { | |||
| switch strings.ToLower(param.Name) { | |||
There was a problem hiding this comment.
Can you separate this change from the rest?
There was a problem hiding this comment.
I don't think that's really necessary, it's just one line (except for the Readme change) and functionally makes no difference to the existing behavior. But if it's easier for review I can if you'd like
There was a problem hiding this comment.
There are other changes in README.md going from lower case to upper case. It's no big deal. It just makes clearer which change is adding the new strategy and which change is allowing the params names to be mix of lower and upper cases.
| @@ -213,6 +214,29 @@ func generateConfigMapString(requestedStrategies []deschedulerv1beta1.Strategy) | |||
| } | |||
| case "nodetaints", "removepodsviolatingnodetaints": | |||
| policy.Strategies["RemovePodsViolatingNodeTaints"] = deschedulerapi.DeschedulerStrategy{Enabled: true} | |||
| case "removepodshavingtoomanyrestarts": | |||
| podsHavingTooManyRestarts := deschedulerapi.PodsHavingTooManyRestarts{} | |||
There was a problem hiding this comment.
Also, let's wait until kubernetes-sigs/descheduler#276 gets merged.
There was a problem hiding this comment.
@ingvagabund the upstream PR has merged, so I updated this as well. Should be all good for a final pass
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle Bug 1833329: Add support for RemovePodsHavingTooManyRestarts strategy |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-unspecified
|
@damemi: This pull request references Bugzilla bug 1833329, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damemi: All pull requests linked via external trackers have merged: openshift/cluster-kube-descheduler-operator#108. Bugzilla bug 1833329 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds the
RemovePodsHavingTooManyRestartsstrategy, added upstream in kubernetes-sigs/descheduler#254 and synced to our fork in openshift/descheduler#29.This also updates the sample CR in the readme to show how to configure this strategy, and I made the change to now convert strategy parameter names to lowercase in our logic, allowing CamelCase params that are imo more readable.