Merge pull request #2196 from afreen23/bug-fix-infotips

Bug fix for infotips in Persistent and Object service dashboards
openshift · Jul 31, 2019 · 5f2a1af · 5f2a1af
2 parents c0f8934 + 2b6c8ff
commit 5f2a1af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...lugin/src/components/dashboard-page/storage-dashboard/data-resiliency/data-resiliency.tsx b/...lugin/src/components/dashboard-page/storage-dashboard/data-resiliency/data-resiliency.tsx
@@ -5,10 +5,11 @@ import { GreenCheckCircleIcon, RedExclamationCircleIcon } from '@console/shared'
 import { DashboardCard } from '@console/internal/components/dashboard/dashboard-card/card';
 import { DashboardCardBody } from '@console/internal/components/dashboard/dashboard-card/card-body';
 import { DashboardCardHeader } from '@console/internal/components/dashboard/dashboard-card/card-header';
+import { DashboardCardHelp } from '@console/internal/components/dashboard/dashboard-card';
 import { DashboardCardTitle } from '@console/internal/components/dashboard/dashboard-card/card-title';
 import {
-  withDashboardResources,
   DashboardItemProps,
+  withDashboardResources,
 } from '@console/internal/components/dashboards-page/with-dashboard-resources';
 import { DATA_RESILIENCY_QUERIES } from '../../../../constants/queries';
 
@@ -71,6 +72,8 @@ const DataResiliency: React.FC<DashboardItemProps> = ({
     'result',
   ]);
 
+  const infoText =
+    'Data Resiliency presents status of data replication and rebalancing operations.';
   const totalPg = getCapacityStats(totalPGRaw);
   const cleanAndActivePg = getCapacityStats(cleanAndActivePGRaw);
 
@@ -82,6 +85,7 @@ const DataResiliency: React.FC<DashboardItemProps> = ({
     <DashboardCard className="ceph-data-resiliency__dashboard-card">
       <DashboardCardHeader>
         <DashboardCardTitle>Data Resiliency</DashboardCardTitle>
+        <DashboardCardHelp>{infoText}</DashboardCardHelp>
       </DashboardCardHeader>
       <DashboardCardBody
         className="ceph-data-resiliency__dashboard-body"

diff --git a/...rage-plugin/src/components/object-data-reduction-card/object-data-reduction-card-item.tsx b/...rage-plugin/src/components/object-data-reduction-card/object-data-reduction-card-item.tsx
@@ -44,7 +44,7 @@ export const SavingsItem: React.FC<SavingsItemProps> = React.memo(
   ({ savings, logicalSize, isLoading }) => {
     let text = <span className="text-secondary">Unavailable</span>;
     const infoText =
-      'Efficiency ratio refers to the deduplication and compression process effectiveness.';
+      'Savings shows the uncompressed and non-deduped data that would have been stored without those techniques';
 
     if (isLoading) {
       text = <LoadingInline />;