Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-3905: (deps) upgrade to webpack 5 #14378

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Oct 4, 2024

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

  • upgraded webpack related dependencies to latest version
  • updated formik from 2.0.3 to 2.1.5 to fix build warning
  • remove cache-loader, null-loader because they are deprecated
  • updated react-dnd from 9.4.0 to 11.1.3 to fix build error
  • switched ts-loader to esbuild-loader for performance
  • switch webpack-virtual-modules with val-loader to fix build warning (and for easier transition to rspack, since it supports most loader APIs)

Reviewers and assignees:

n/a

Test cases:

  • Does @console/internal/file-input still work as expected?
  • Are there any regressions with formik or react-dnd?
  • Do all the Monaco YAML language server features work?
  • Do all dynamic and static plugins work as expected?
  • Does everything else work the same?

Additional info:

n/a

Screen shots / gifs / design review:

n/a

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2024

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

- upgraded webpack and related dependencies to latest version - updated formik from 2.0.3 to 2.1.5 to fix build warning - remove cache-loader, null-loader because they are deprecated

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 4, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2024

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

  • upgraded webpack and related dependencies to latest version
  • updated formik from 2.0.3 to 2.1.5 to fix build warning
  • remove cache-loader, null-loader because they are deprecated

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Oct 4, 2024
@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch from 869d212 to a4f5dcf Compare October 5, 2024 00:38
@logonoff
Copy link
Member Author

logonoff commented Oct 5, 2024

/retest e2e-gcp-console

Copy link
Contributor

openshift-ci bot commented Oct 5, 2024

@logonoff: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images

The following commands are available to trigger optional jobs:

  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images

In response to this:

/retest e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch from 4ce69e2 to 464ba9e Compare October 7, 2024 12:22
@logonoff logonoff changed the title CONSOLE-3905: (deps) upgrade to webpack 5.95 CONSOLE-3905: (deps) upgrade to webpack 5.95 (wip) Oct 7, 2024
@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch 3 times, most recently from 9173d3c to 44b6e7c Compare October 8, 2024 20:23
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2024

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

  • upgraded webpack and related dependencies to latest version
  • updated formik from 2.0.3 to 2.1.5 to fix build warning
  • remove cache-loader, null-loader because they are deprecated
  • updated react-dnd from 9.4.0 to 11.1.3 to fix build error

Reviewers and assignees:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch from 44b6e7c to 8ff2876 Compare October 8, 2024 20:28
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2024

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

  • upgraded webpack and related dependencies to latest version
  • updated formik from 2.0.3 to 2.1.5 to fix build warning
  • remove cache-loader, null-loader because they are deprecated
  • updated react-dnd from 9.4.0 to 11.1.3 to fix build error

Reviewers and assignees:

n/a

Additional info:

[wip] I have some runtime errors, such as _TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefined and can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization, which seem to suggest there are some cyclical imports which I'm not really sure how to deal with

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch 2 times, most recently from 56a128f to 83ba265 Compare October 10, 2024 18:55
@openshift-ci openshift-ci bot added the component/knative Related to knative-plugin label Oct 10, 2024
@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch 4 times, most recently from d23de74 to e65a660 Compare October 16, 2024 19:37
@logonoff logonoff changed the title CONSOLE-3905: (deps) upgrade to webpack 5.95 (wip) CONSOLE-3905: (deps) upgrade to webpack 5 (wip) Oct 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2024

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

  • upgraded webpack related dependencies to latest version
  • upgraded webpack to 5.75 to match plugins
  • updated formik from 2.0.3 to 2.1.5 to fix build warning
  • remove cache-loader, null-loader because they are deprecated
  • updated react-dnd from 9.4.0 to 11.1.3 to fix build error

Reviewers and assignees:

n/a

Additional info:

[wip] I have some runtime errors, such as _TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefined and can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization, which seem to suggest there are some cyclical imports which I'm not really sure how to deal with

Screen shots / gifs / design review:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch from e65a660 to 7639885 Compare October 16, 2024 21:18
@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch 2 times, most recently from 91b5351 to 0f7beeb Compare December 5, 2024 05:42
@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch 2 times, most recently from dd42c30 to 3ccd033 Compare December 5, 2024 19:57
@vojtechszocs
Copy link
Contributor

/lgtm

@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch from 3ccd033 to b066e5a Compare December 5, 2024 20:13
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 5, 2024
@logonoff
Copy link
Member Author

logonoff commented Dec 5, 2024

Jira ticket for throwing warnings on guessModuleFilePath usage: https://issues.redhat.com/browse/CONSOLE-4382

@logonoff logonoff force-pushed the CONSOLE-3905-webpack-5 branch from 4a4c6cb to 0591f54 Compare December 5, 2024 20:35
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 36bee3e into openshift:master Dec 6, 2024
6 of 7 checks passed
@logonoff
Copy link
Member Author

logonoff commented Dec 6, 2024

/honk

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@logonoff:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff logonoff deleted the CONSOLE-3905-webpack-5 branch December 6, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants