add extension to contribute arbitrary pages #1668
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
lgtm
|
@christianvogt How do we handle shared routes for use cases where we want two different perspectives to share the same view using this plugin? Is there a way for the plugin to say that I want to reuse a particular view from main console app but in a different perspective? |
christianvogt
force-pushed
the
ext-pages
branch
2 times, most recently
from
e57e9a2 to
1e277dc
Compare
|
@rohitkrai03 It was decided a while back that the dev perspective is just a customized nav. So all views are available to all perspectives. |
|
/retest |
|
/retest |
| @@ -90,7 +92,7 @@ const plugin: Plugin<ConsumedExtensions> = [ | |||
| }, | |||
| }, | |||
| { | |||
| type: 'ResourcePage/Detail', | |||
| type: 'Page/Resource/Details', | |||
There was a problem hiding this comment.
nitpick: Why plural, please?
There was a problem hiding this comment.
There are several references in code to both detail and details (more plural); with no apparent consistency. It seemed to me the choice for plural made more sense as per the contents of the pages containing several sections under a tabbed navigation. This to me implied several details as oppose to a single all inclusive detail about the resource.
If there is a particular reason to use the singular form, I'm happy to go with that as I am unfamiliar with the history of this repo.
@spadgett thoughts?
There was a problem hiding this comment.
Like @christianvogt, I have a preference for "details." It's not a single detail. Resources have many properties. It's many details :)
There's no particular history that I'm aware of. We should try to be consistent.
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jtomasek, spadgett, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Adds extension to allow plugins to contribute pages which render arbitrary react components. This is required by the dev console to render pages that are not based on a single resource and therefore cannot be contributed through the existing resource list / details page extensions.
Changes
resourceDetailPagestoresourceDetailsPagestypeof existing extensionsResourcePage/ListandResourcePage/Detail/cc @vojtechszocs @spadgett
fyi @jtomasek @rohitkrai03