Add standard Resource > Resource Details breadcrumb to resource det…
#1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
removing LOC while adding functionality 👍 |
spadgett
reviewed
Jun 14, 2019
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
4 tasks
|
/retest Please review the full test history for this PR and help us cut down flakes. |
rhamilto
force-pushed
the
breadcrumb-changes
branch
from
8c2ed17 to
04f00a2
Compare
rhamilto
force-pushed
the
breadcrumb-changes
branch
from
04f00a2 to
40c57e6
Compare
|
@spadgett, OLM e2e tests should be fixed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ails pages
Fixes https://jira.coreos.com/browse/CONSOLE-1539
A few special cases:
Opted not to special case pages where we aggregate resources in to a special list (e.g., Cluster Settings > Global Configuration) to keep things as simple as possible, but can be convinced otherwise.