Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where pod donut was not showing terminating status on scaling down #2240

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Fix bug where pod donut was not showing terminating status on scaling down #2240

merged 1 commit into from
Aug 1, 2019

Conversation

divyanshiGupta
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2019
@gijohn
Copy link
Contributor

gijohn commented Aug 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@divyanshiGupta
Copy link
Contributor Author

/test e2e-aws

@christianvogt
Copy link
Contributor

@divyanshiGupta please also fix line 68. if (_.has(pod, ['metadata.deletionTimestamp'])) {

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@divyanshiGupta
Copy link
Contributor Author

@christianvogt done.

@christianvogt
Copy link
Contributor

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, gijohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@divyanshiGupta
Copy link
Contributor Author

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f977e5a into openshift:master Aug 1, 2019
@spadgett spadgett added this to the v4.2 milestone Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gijohn gijohn Awaiting requested review from gijohn

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@gijohn gijohn

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
7 participants
@divyanshiGupta @gijohn @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot