Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure icons have same size/Fix incorrect vm off icon size #2248

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Make sure icons have same size/Fix incorrect vm off icon size #2248

merged 1 commit into from
Aug 13, 2019

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Aug 2, 2019 •
edited
Loading

@rawagner
Copy link
Contributor Author

rawagner commented Aug 2, 2019

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. component/kubevirt Related to kubevirt-plugin size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2019
@rawagner
Make sure icons have same size.
42f13c4 
Kubevirt: Fix incorrect vm off icon size.
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2019
@rawagner rawagner changed the title Fix incorrect vm off icon size Make sure icons have same size/Fix incorrect vm off icon size Aug 2, 2019
@joshuawilson
Copy link
Contributor

Can you please add a link to the bug in the description.

@rawagner
Copy link
Contributor Author

rawagner commented Aug 5, 2019

@joshuawilson description updated

@pcbailey
Copy link
Contributor

pcbailey commented Aug 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@vojtechszocs
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9ede6e4 into openshift:master Aug 13, 2019
@openshift-ci-robot
Copy link
Contributor

@rawagner: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 42f13c4 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett added this to the v4.2 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
7 participants
@rawagner @joshuawilson @pcbailey @vojtechszocs @openshift-ci-robot @spadgett @openshift-merge-robot