Bug-fix: Fixing updated prometheus queries in object service dashboard #2255
Conversation
openshift-ci-robot
added
the
size/M
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
afreen23
force-pushed
the
bug-fix-prometheus-query
branch
3 times, most recently
from
ec7260a to
52a032d
Compare
|
@rawagner @cloudbehl please review the PR |
| : null; | ||
| const savingsFormattted = humanizeBinaryBytesWithoutB(Number(savings)); | ||
| text = ( | ||
| <span className="nb-object-data-reduction-card__row-status-item-text"> | ||
| {savingsFormattted.value} | ||
| {savingsFormattted.unit}({savingsPercentage.string}) | ||
| {savingsFormattted.unit} |
There was a problem hiding this comment.
you should use savingsFormattted.string instead of value and unit as string property adds space between unit and value per unit definition.
also it seems to me that savingsFormattted and savingsPercentage is going to be shown right next to each other without any space ? like 20Ki(10%) ?
There was a problem hiding this comment.
@rawagner yes as per the mock https://projects.invisionapp.com/share/BRS4A5ETN3H#/screens/364134659_Object_storage_Dashboard-_IO_operations_for_providers
its together without space
There was a problem hiding this comment.
made it spacious @rawagner so as to be consistent with overall console
openshift-ci-robot
added
the
approved
change of num pools query in health card change of savings query in object data reduction card change of system name query in details card Signed-off-by: Afreen Rahman <afrahman@redhat.com>
afreen23
force-pushed
the
bug-fix-prometheus-query
branch
from
52a032d to
6383368
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, cloudbehl, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-console |
https://jira.coreos.com/browse/RHSTOR-662
change of num pools and buckets query in health card
change of savings query in object data reduction card
change of system name query in details card
The changed queries are raising bugs and some can raise bugs in object service dashboard.